[GitHub] [cloudstack] soreana opened a new pull request #4768: display nics deviceid and order nics by deviceid on Nics tab of insta…

Mon, 08 Mar 2021 00:11:58 -0800 


soreana opened a new pull request #4768:
URL: https://github.com/apache/cloudstack/pull/4768


   ### Description
   
   As a cloudstack team, we want to show sorted NICs in the Nic tab of the 
instance and API calls. To achieve this goal, cloudstack should put the 
deviceid in userVmResponse. This is the minor PR to add this feature.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- 
*********************************************************************************
 -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE 
DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- 
*********************************************************************************
 -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   
   ### Screenshots (if appropriate):
   ![Screenshot 2021-03-08 at 04 27 
21](https://user-images.githubusercontent.com/9499410/110270779-e0ff1e00-7fc6-11eb-9cdb-8cf015818102.png)
   
   
   ### How Has This Been Tested?
   
   I deployed the following instance in my test environment with three 
networks, as you can see they are sorted in NIC tab.
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to