CLOUDSTACK-2553: Made ACL item action case-insensitive
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/612afbd1 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/612afbd1 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/612afbd1 Branch: refs/heads/vmware-datamodel Commit: 612afbd17941ee840b1bba3e5951f89cafeea243 Parents: 32e7ba2 Author: Kishan Kavala <kis...@cloud.com> Authored: Mon May 20 17:58:14 2013 +0530 Committer: Kishan Kavala <kis...@cloud.com> Committed: Mon May 20 18:06:12 2013 +0530 ---------------------------------------------------------------------- .../cloud/network/vpc/NetworkACLServiceImpl.java | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/612afbd1/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java b/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java index 4d5d981..2b02a88 100644 --- a/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java +++ b/server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java @@ -342,9 +342,7 @@ public class NetworkACLServiceImpl extends ManagerBase implements NetworkACLServ //Check ofr valid action Allow/Deny if(action != null){ - try { - NetworkACLItem.Action.valueOf(action); - } catch (IllegalArgumentException ex) { + if(!("Allow".equalsIgnoreCase(action) || "Deny".equalsIgnoreCase(action))){ throw new InvalidParameterValueException("Invalid action. Allowed actions are Allow and Deny"); } }
