QuickCloud: remove cyclic dependency introduced in nonoss build by moving SecondaryStorageDiscoverer into services However with this fix, developers will be unable to run 'PremiumSecondaryStorageResource' (for VMWare installations) using mvn exec:java. Instead they will have to use the exploded archive from systemvm.zip
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/db5e1f01 Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/db5e1f01 Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/db5e1f01 Branch: refs/heads/quickcloud Commit: db5e1f0106098910948e88e760f2377c8ef219cc Parents: a6a82f6 Author: Chiradeep Vittal <chirad...@apache.org> Authored: Wed Mar 27 14:07:20 2013 -0700 Committer: Chiradeep Vittal <chirad...@apache.org> Committed: Wed Mar 27 14:07:20 2013 -0700 ---------------------------------------------------------------------- client/tomcatconf/componentContext.xml.in | 2 +- client/tomcatconf/nonossComponentContext.xml.in | 2 +- .../tomcatconf/quickCloudComponentContext.xml.in | 2 +- plugins/hypervisors/simulator/pom.xml | 5 + .../resource/SimulatorSecondaryDiscoverer.java | 3 +- plugins/hypervisors/vmware/pom.xml | 5 + server/pom.xml | 5 - .../secondary/SecondaryStorageDiscoverer.java | 322 --------------- services/console-proxy/server/pom.xml | 5 + services/secondary-storage/pom.xml | 28 +- .../resource/SecondaryStorageDiscoverer.java | 320 ++++++++++++++ 11 files changed, 344 insertions(+), 355 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/client/tomcatconf/componentContext.xml.in ---------------------------------------------------------------------- diff --git a/client/tomcatconf/componentContext.xml.in b/client/tomcatconf/componentContext.xml.in index a98a41f..3226e61 100644 --- a/client/tomcatconf/componentContext.xml.in +++ b/client/tomcatconf/componentContext.xml.in @@ -213,7 +213,7 @@ </bean> --> - <bean id="SecondaryStorageDiscoverer" class="com.cloud.storage.secondary.SecondaryStorageDiscoverer"> + <bean id="SecondaryStorageDiscoverer" class="org.apache.cloudstack.storage.resource.SecondaryStorageDiscoverer"> <property name="name" value="SecondaryStorage"/> </bean> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/client/tomcatconf/nonossComponentContext.xml.in ---------------------------------------------------------------------- diff --git a/client/tomcatconf/nonossComponentContext.xml.in b/client/tomcatconf/nonossComponentContext.xml.in index 8f8dae5..5bbd946 100644 --- a/client/tomcatconf/nonossComponentContext.xml.in +++ b/client/tomcatconf/nonossComponentContext.xml.in @@ -217,7 +217,7 @@ <property name="name" value="XCP Agent"/> </bean> - <bean id="SecondaryStorageDiscoverer" class="com.cloud.storage.secondary.SecondaryStorageDiscoverer"> + <bean id="SecondaryStorageDiscoverer" class="org.apache.cloudstack.storage.resource..SecondaryStorageDiscoverer"> <property name="name" value="SecondaryStorage"/> </bean> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/client/tomcatconf/quickCloudComponentContext.xml.in ---------------------------------------------------------------------- diff --git a/client/tomcatconf/quickCloudComponentContext.xml.in b/client/tomcatconf/quickCloudComponentContext.xml.in index 63e2266..dbd3117 100644 --- a/client/tomcatconf/quickCloudComponentContext.xml.in +++ b/client/tomcatconf/quickCloudComponentContext.xml.in @@ -213,7 +213,7 @@ </bean> --> - <bean id="SecondaryStorageDiscoverer" class="com.cloud.storage.secondary.SecondaryStorageDiscoverer"> + <bean id="SecondaryStorageDiscoverer" class="org.apache.cloudstack.storage.resource.SecondaryStorageDiscoverer"> <property name="name" value="SecondaryStorage"/> </bean> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/plugins/hypervisors/simulator/pom.xml ---------------------------------------------------------------------- diff --git a/plugins/hypervisors/simulator/pom.xml b/plugins/hypervisors/simulator/pom.xml index ff1664a..e4ca927 100644 --- a/plugins/hypervisors/simulator/pom.xml +++ b/plugins/hypervisors/simulator/pom.xml @@ -40,5 +40,10 @@ <artifactId>cloud-utils</artifactId> <version>${project.version}</version> </dependency> + <dependency> + <groupId>org.apache.cloudstack</groupId> + <artifactId>cloud-secondary-storage</artifactId> + <version>${project.version}</version> + </dependency> </dependencies> </project> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorSecondaryDiscoverer.java ---------------------------------------------------------------------- diff --git a/plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorSecondaryDiscoverer.java b/plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorSecondaryDiscoverer.java index 3a8cf17..c121fba 100644 --- a/plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorSecondaryDiscoverer.java +++ b/plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorSecondaryDiscoverer.java @@ -24,6 +24,7 @@ import javax.ejb.Local; import javax.inject.Inject; import javax.naming.ConfigurationException; +import org.apache.cloudstack.storage.resource.SecondaryStorageDiscoverer; import org.apache.log4j.Logger; import com.cloud.agent.AgentManager; @@ -40,9 +41,7 @@ import com.cloud.host.HostVO; import com.cloud.host.Status; import com.cloud.storage.SnapshotVO; import com.cloud.storage.dao.SnapshotDao; -import com.cloud.storage.secondary.SecondaryStorageDiscoverer; import com.cloud.utils.exception.CloudRuntimeException; -import org.springframework.stereotype.Component; @Local(value=Discoverer.class) http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/plugins/hypervisors/vmware/pom.xml ---------------------------------------------------------------------- diff --git a/plugins/hypervisors/vmware/pom.xml b/plugins/hypervisors/vmware/pom.xml index 468e0a5..d65ef64 100644 --- a/plugins/hypervisors/vmware/pom.xml +++ b/plugins/hypervisors/vmware/pom.xml @@ -33,6 +33,11 @@ <version>${project.version}</version> </dependency> <dependency> + <groupId>org.apache.cloudstack</groupId> + <artifactId>cloud-secondary-storage</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> <groupId>com.cloud.com.vmware</groupId> <artifactId>vmware-vim25</artifactId> <version>${cs.vmware.api.version}</version> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/server/pom.xml ---------------------------------------------------------------------- diff --git a/server/pom.xml b/server/pom.xml index 5f8d2b6..b39f731 100644 --- a/server/pom.xml +++ b/server/pom.xml @@ -32,11 +32,6 @@ <version>${project.version}</version> </dependency> <dependency> - <groupId>org.apache.cloudstack</groupId> - <artifactId>cloud-secondary-storage</artifactId> - <version>${project.version}</version> - </dependency> - <dependency> <groupId>javax.servlet</groupId> <artifactId>servlet-api</artifactId> <version>${cs.servlet.version}</version> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java b/server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java deleted file mode 100755 index 6e66e0d..0000000 --- a/server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java +++ /dev/null @@ -1,322 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. -package com.cloud.storage.secondary; - -import java.io.File; -import java.lang.reflect.Constructor; -import java.lang.reflect.InvocationTargetException; -import java.net.URI; -import java.util.Date; -import java.util.HashMap; -import java.util.List; -import java.util.Map; -import java.util.Random; - -import javax.ejb.Local; -import javax.inject.Inject; -import javax.naming.ConfigurationException; - -import org.apache.cloudstack.storage.resource.LocalSecondaryStorageResource; -import org.apache.cloudstack.storage.resource.NfsSecondaryStorageResource; -import org.apache.log4j.Logger; - -import com.cloud.agent.AgentManager; -import com.cloud.configuration.dao.ConfigurationDao; -import com.cloud.host.HostVO; -import com.cloud.host.Status.Event; -import com.cloud.host.dao.HostDao; -import com.cloud.hypervisor.Hypervisor; -import com.cloud.resource.Discoverer; -import com.cloud.resource.DiscovererBase; -import com.cloud.resource.ServerResource; -import com.cloud.storage.VMTemplateVO; -import com.cloud.storage.VMTemplateZoneVO; -import com.cloud.storage.dao.VMTemplateDao; -import com.cloud.storage.dao.VMTemplateHostDao; -import com.cloud.storage.dao.VMTemplateZoneDao; -import com.cloud.storage.resource.DummySecondaryStorageResource; -import com.cloud.utils.component.ComponentContext; -import com.cloud.utils.net.NfsUtils; -import com.cloud.utils.script.Script; - -/** - * SecondaryStorageDiscoverer is used to discover secondary - * storage servers and make sure everything it can do is - * correct. - */ -@Local(value=Discoverer.class) -public class SecondaryStorageDiscoverer extends DiscovererBase implements Discoverer { - private static final Logger s_logger = Logger.getLogger(SecondaryStorageDiscoverer.class); - - long _timeout = 2 * 60 * 1000; // 2 minutes - String _mountParent; - boolean _useServiceVM = false; - - Random _random = new Random(System.currentTimeMillis()); - @Inject - protected HostDao _hostDao = null; - @Inject - protected VMTemplateDao _tmpltDao = null; - @Inject - protected VMTemplateHostDao _vmTemplateHostDao = null; - @Inject - protected VMTemplateZoneDao _vmTemplateZoneDao = null; - @Inject - protected VMTemplateDao _vmTemplateDao = null; - @Inject - protected ConfigurationDao _configDao = null; - @Inject - protected AgentManager _agentMgr = null; - - protected SecondaryStorageDiscoverer() { - } - - @Override - public Map<? extends ServerResource, Map<String, String>> find(long dcId, Long podId, Long clusterId, URI uri, String username, String password, List<String> hostTags) { - if (!uri.getScheme().equalsIgnoreCase("nfs") && !uri.getScheme().equalsIgnoreCase("file") - && !uri.getScheme().equalsIgnoreCase("iso") && !uri.getScheme().equalsIgnoreCase("dummy")) { - s_logger.debug("It's not NFS or file or ISO, so not a secondary storage server: " + uri.toString()); - return null; - } - - if (uri.getScheme().equalsIgnoreCase("nfs") || uri.getScheme().equalsIgnoreCase("iso")) { - return createNfsSecondaryStorageResource(dcId, podId, uri); - } else if (uri.getScheme().equalsIgnoreCase("file")) { - return createLocalSecondaryStorageResource(dcId, podId, uri); - } else if (uri.getScheme().equalsIgnoreCase("dummy")) { - return createDummySecondaryStorageResource(dcId, podId, uri); - } else { - return null; - } - } - - protected Map<? extends ServerResource, Map<String, String>> createNfsSecondaryStorageResource(long dcId, Long podId, URI uri) { - - if (_useServiceVM) { - return createDummySecondaryStorageResource(dcId, podId, uri); - } - String mountStr = NfsUtils.uri2Mount(uri); - - Script script = new Script(true, "mount", _timeout, s_logger); - String mntPoint = null; - File file = null; - do { - mntPoint = _mountParent + File.separator + Integer.toHexString(_random.nextInt(Integer.MAX_VALUE)); - file = new File(mntPoint); - } while (file.exists()); - - if (!file.mkdirs()) { - s_logger.warn("Unable to make directory: " + mntPoint); - return null; - } - - script.add(mountStr, mntPoint); - String result = script.execute(); - if (result != null && !result.contains("already mounted")) { - s_logger.warn("Unable to mount " + uri.toString() + " due to " + result); - file.delete(); - return null; - } - - script = new Script(true, "umount", 0, s_logger); - script.add(mntPoint); - script.execute(); - - file.delete(); - - Map<NfsSecondaryStorageResource, Map<String, String>> srs = new HashMap<NfsSecondaryStorageResource, Map<String, String>>(); - - NfsSecondaryStorageResource storage; - if(_configDao.isPremium()) { - Class<?> impl; - String name = "com.cloud.storage.resource.PremiumSecondaryStorageResource"; - try { - impl = Class.forName(name); - final Constructor<?> constructor = impl.getDeclaredConstructor(); - constructor.setAccessible(true); - storage = (NfsSecondaryStorageResource)constructor.newInstance(); - } catch (final ClassNotFoundException e) { - s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to ClassNotFoundException"); - return null; - } catch (final SecurityException e) { - s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to SecurityException"); - return null; - } catch (final NoSuchMethodException e) { - s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to NoSuchMethodException"); - return null; - } catch (final IllegalArgumentException e) { - s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to IllegalArgumentException"); - return null; - } catch (final InstantiationException e) { - s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to InstantiationException"); - return null; - } catch (final IllegalAccessException e) { - s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to IllegalAccessException"); - return null; - } catch (final InvocationTargetException e) { - s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to InvocationTargetException"); - return null; - } - } else { - storage = new NfsSecondaryStorageResource(); - } - - Map<String, String> details = new HashMap<String, String>(); - details.put("mount.path", mountStr); - details.put("orig.url", uri.toString()); - details.put("mount.parent", _mountParent); - - Map<String, Object> params = new HashMap<String, Object>(); - params.putAll(details); - params.put("zone", Long.toString(dcId)); - if (podId != null) { - params.put("pod", podId.toString()); - } - params.put("guid", uri.toString()); - params.put("secondary.storage.vm", "false"); - params.put("max.template.iso.size", _configDao.getValue("max.template.iso.size")); - - try { - storage.configure("Storage", params); - } catch (ConfigurationException e) { - s_logger.warn("Unable to configure the storage ", e); - return null; - } - srs.put(storage, details); - - return srs; - } - - protected Map<? extends ServerResource, Map<String, String>> createLocalSecondaryStorageResource(long dcId, Long podId, URI uri) { - Map<LocalSecondaryStorageResource, Map<String, String>> srs = new HashMap<LocalSecondaryStorageResource, Map<String, String>>(); - - LocalSecondaryStorageResource storage = new LocalSecondaryStorageResource(); - storage = ComponentContext.inject(storage); - - Map<String, String> details = new HashMap<String, String>(); - - File file = new File(uri); - details.put("mount.path", file.getAbsolutePath()); - details.put("orig.url", uri.toString()); - - Map<String, Object> params = new HashMap<String, Object>(); - params.putAll(details); - params.put("zone", Long.toString(dcId)); - if (podId != null) { - params.put("pod", podId.toString()); - } - params.put("guid", uri.toString()); - - try { - storage.configure("Storage", params); - } catch (ConfigurationException e) { - s_logger.warn("Unable to configure the storage ", e); - return null; - } - srs.put(storage, details); - - return srs; - } - - protected Map<ServerResource, Map<String, String>> createDummySecondaryStorageResource(long dcId, Long podId, URI uri) { - Map<ServerResource, Map<String, String>> srs = new HashMap<ServerResource, Map<String, String>>(); - - DummySecondaryStorageResource storage = new DummySecondaryStorageResource(_useServiceVM); - storage = ComponentContext.inject(storage); - - Map<String, String> details = new HashMap<String, String>(); - - details.put("mount.path", uri.toString()); - details.put("orig.url", uri.toString()); - - Map<String, Object> params = new HashMap<String, Object>(); - params.putAll(details); - params.put("zone", Long.toString(dcId)); - if (podId != null) { - params.put("pod", podId.toString()); - } - params.put("guid", uri.toString()); - - try { - storage.configure("Storage", params); - } catch (ConfigurationException e) { - s_logger.warn("Unable to configure the storage ", e); - return null; - } - srs.put(storage, details); - - return srs; - } - - @Override - public boolean configure(String name, Map<String, Object> params) throws ConfigurationException { - super.configure(name, params); - - _mountParent = _params.get("mount.parent"); - if (_mountParent == null) { - _mountParent = "/mnt"; - } - - String useServiceVM = _params.get("secondary.storage.vm"); - if ("true".equalsIgnoreCase(useServiceVM)){ - _useServiceVM = true; - } - return true; - } - - @Override - public boolean matchHypervisor(String hypervisor) { - if( hypervisor.equals("SecondaryStorage")) { - return true; - } else { - return false; - } - } - - @Override - public Hypervisor.HypervisorType getHypervisorType() { - return Hypervisor.HypervisorType.None; - } - - @Override - public void postDiscovery(List<HostVO> hosts, long msId) { - if (_useServiceVM) { - for (HostVO h: hosts) { - _agentMgr.agentStatusTransitTo(h, Event.AgentDisconnected, msId); - } - } - for (HostVO h: hosts) { - associateTemplatesToZone(h.getId(), h.getDataCenterId()); - } - - } - - private void associateTemplatesToZone(long hostId, long dcId){ - VMTemplateZoneVO tmpltZone; - - List<VMTemplateVO> allTemplates = _vmTemplateDao.listAll(); - for (VMTemplateVO vt: allTemplates){ - if (vt.isCrossZones()) { - tmpltZone = _vmTemplateZoneDao.findByZoneTemplate(dcId, vt.getId()); - if (tmpltZone == null) { - VMTemplateZoneVO vmTemplateZone = new VMTemplateZoneVO(dcId, vt.getId(), new Date()); - _vmTemplateZoneDao.persist(vmTemplateZone); - } - } - } - } -} http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/services/console-proxy/server/pom.xml ---------------------------------------------------------------------- diff --git a/services/console-proxy/server/pom.xml b/services/console-proxy/server/pom.xml index 19d8eb4..aec6d18 100644 --- a/services/console-proxy/server/pom.xml +++ b/services/console-proxy/server/pom.xml @@ -57,6 +57,11 @@ <version>${project.version}</version> <type>pom</type> </dependency> + <dependency> + <groupId>org.apache.cloudstack</groupId> + <artifactId>cloud-secondary-storage</artifactId> + <version>${project.version}</version> + </dependency> </dependencies> <build> <defaultGoal>install</defaultGoal> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/services/secondary-storage/pom.xml ---------------------------------------------------------------------- diff --git a/services/secondary-storage/pom.xml b/services/secondary-storage/pom.xml index d8dbf1d..0577084 100644 --- a/services/secondary-storage/pom.xml +++ b/services/secondary-storage/pom.xml @@ -54,6 +54,11 @@ <version>${project.version}</version> <type>pom</type> </dependency> + <dependency> + <groupId>org.apache.cloudstack</groupId> + <artifactId>cloud-server</artifactId> + <version>${project.version}</version> + </dependency> </dependencies> <build> <defaultGoal>install</defaultGoal> @@ -87,27 +92,4 @@ </plugin> </plugins> </build> - <profiles> - <profile> - <id>vmware</id> - <activation> - <property> - <name>nonoss</name> - </property> - </activation> - <dependencies> - <dependency> - <groupId>org.apache.cloudstack</groupId> - <artifactId>cloud-plugin-hypervisor-vmware</artifactId> - <version>${project.version}</version> - </dependency> - <dependency> - <groupId>org.apache.cloudstack</groupId> - <artifactId>cloud-vmware-base</artifactId> - <version>${project.version}</version> - </dependency> - </dependencies> - </profile> - </profiles> - </project> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/db5e1f01/services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java ---------------------------------------------------------------------- diff --git a/services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java b/services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java new file mode 100755 index 0000000..d3af792 --- /dev/null +++ b/services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java @@ -0,0 +1,320 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package org.apache.cloudstack.storage.resource; + +import java.io.File; +import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; +import java.net.URI; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Random; + +import javax.ejb.Local; +import javax.inject.Inject; +import javax.naming.ConfigurationException; + +import org.apache.log4j.Logger; + +import com.cloud.agent.AgentManager; +import com.cloud.configuration.dao.ConfigurationDao; +import com.cloud.host.HostVO; +import com.cloud.host.Status.Event; +import com.cloud.host.dao.HostDao; +import com.cloud.hypervisor.Hypervisor; +import com.cloud.resource.Discoverer; +import com.cloud.resource.DiscovererBase; +import com.cloud.resource.ServerResource; +import com.cloud.storage.VMTemplateVO; +import com.cloud.storage.VMTemplateZoneVO; +import com.cloud.storage.dao.VMTemplateDao; +import com.cloud.storage.dao.VMTemplateHostDao; +import com.cloud.storage.dao.VMTemplateZoneDao; +import com.cloud.storage.resource.DummySecondaryStorageResource; +import com.cloud.utils.component.ComponentContext; +import com.cloud.utils.net.NfsUtils; +import com.cloud.utils.script.Script; + +/** + * SecondaryStorageDiscoverer is used to discover secondary + * storage servers and make sure everything it can do is + * correct. + */ +@Local(value=Discoverer.class) +public class SecondaryStorageDiscoverer extends DiscovererBase implements Discoverer { + private static final Logger s_logger = Logger.getLogger(SecondaryStorageDiscoverer.class); + + long _timeout = 2 * 60 * 1000; // 2 minutes + String _mountParent; + boolean _useServiceVM = false; + + Random _random = new Random(System.currentTimeMillis()); + @Inject + protected HostDao _hostDao = null; + @Inject + protected VMTemplateDao _tmpltDao = null; + @Inject + protected VMTemplateHostDao _vmTemplateHostDao = null; + @Inject + protected VMTemplateZoneDao _vmTemplateZoneDao = null; + @Inject + protected VMTemplateDao _vmTemplateDao = null; + @Inject + protected ConfigurationDao _configDao = null; + @Inject + protected AgentManager _agentMgr = null; + + protected SecondaryStorageDiscoverer() { + } + + @Override + public Map<? extends ServerResource, Map<String, String>> find(long dcId, Long podId, Long clusterId, URI uri, String username, String password, List<String> hostTags) { + if (!uri.getScheme().equalsIgnoreCase("nfs") && !uri.getScheme().equalsIgnoreCase("file") + && !uri.getScheme().equalsIgnoreCase("iso") && !uri.getScheme().equalsIgnoreCase("dummy")) { + s_logger.debug("It's not NFS or file or ISO, so not a secondary storage server: " + uri.toString()); + return null; + } + + if (uri.getScheme().equalsIgnoreCase("nfs") || uri.getScheme().equalsIgnoreCase("iso")) { + return createNfsSecondaryStorageResource(dcId, podId, uri); + } else if (uri.getScheme().equalsIgnoreCase("file")) { + return createLocalSecondaryStorageResource(dcId, podId, uri); + } else if (uri.getScheme().equalsIgnoreCase("dummy")) { + return createDummySecondaryStorageResource(dcId, podId, uri); + } else { + return null; + } + } + + protected Map<? extends ServerResource, Map<String, String>> createNfsSecondaryStorageResource(long dcId, Long podId, URI uri) { + + if (_useServiceVM) { + return createDummySecondaryStorageResource(dcId, podId, uri); + } + String mountStr = NfsUtils.uri2Mount(uri); + + Script script = new Script(true, "mount", _timeout, s_logger); + String mntPoint = null; + File file = null; + do { + mntPoint = _mountParent + File.separator + Integer.toHexString(_random.nextInt(Integer.MAX_VALUE)); + file = new File(mntPoint); + } while (file.exists()); + + if (!file.mkdirs()) { + s_logger.warn("Unable to make directory: " + mntPoint); + return null; + } + + script.add(mountStr, mntPoint); + String result = script.execute(); + if (result != null && !result.contains("already mounted")) { + s_logger.warn("Unable to mount " + uri.toString() + " due to " + result); + file.delete(); + return null; + } + + script = new Script(true, "umount", 0, s_logger); + script.add(mntPoint); + script.execute(); + + file.delete(); + + Map<NfsSecondaryStorageResource, Map<String, String>> srs = new HashMap<NfsSecondaryStorageResource, Map<String, String>>(); + + NfsSecondaryStorageResource storage; + if(_configDao.isPremium()) { + Class<?> impl; + String name = "com.cloud.storage.resource.PremiumSecondaryStorageResource"; + try { + impl = Class.forName(name); + final Constructor<?> constructor = impl.getDeclaredConstructor(); + constructor.setAccessible(true); + storage = (NfsSecondaryStorageResource)constructor.newInstance(); + } catch (final ClassNotFoundException e) { + s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to ClassNotFoundException"); + return null; + } catch (final SecurityException e) { + s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to SecurityException"); + return null; + } catch (final NoSuchMethodException e) { + s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to NoSuchMethodException"); + return null; + } catch (final IllegalArgumentException e) { + s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to IllegalArgumentException"); + return null; + } catch (final InstantiationException e) { + s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to InstantiationException"); + return null; + } catch (final IllegalAccessException e) { + s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to IllegalAccessException"); + return null; + } catch (final InvocationTargetException e) { + s_logger.error("Unable to load com.cloud.storage.resource.PremiumSecondaryStorageResource due to InvocationTargetException"); + return null; + } + } else { + storage = new NfsSecondaryStorageResource(); + } + + Map<String, String> details = new HashMap<String, String>(); + details.put("mount.path", mountStr); + details.put("orig.url", uri.toString()); + details.put("mount.parent", _mountParent); + + Map<String, Object> params = new HashMap<String, Object>(); + params.putAll(details); + params.put("zone", Long.toString(dcId)); + if (podId != null) { + params.put("pod", podId.toString()); + } + params.put("guid", uri.toString()); + params.put("secondary.storage.vm", "false"); + params.put("max.template.iso.size", _configDao.getValue("max.template.iso.size")); + + try { + storage.configure("Storage", params); + } catch (ConfigurationException e) { + s_logger.warn("Unable to configure the storage ", e); + return null; + } + srs.put(storage, details); + + return srs; + } + + protected Map<? extends ServerResource, Map<String, String>> createLocalSecondaryStorageResource(long dcId, Long podId, URI uri) { + Map<LocalSecondaryStorageResource, Map<String, String>> srs = new HashMap<LocalSecondaryStorageResource, Map<String, String>>(); + + LocalSecondaryStorageResource storage = new LocalSecondaryStorageResource(); + storage = ComponentContext.inject(storage); + + Map<String, String> details = new HashMap<String, String>(); + + File file = new File(uri); + details.put("mount.path", file.getAbsolutePath()); + details.put("orig.url", uri.toString()); + + Map<String, Object> params = new HashMap<String, Object>(); + params.putAll(details); + params.put("zone", Long.toString(dcId)); + if (podId != null) { + params.put("pod", podId.toString()); + } + params.put("guid", uri.toString()); + + try { + storage.configure("Storage", params); + } catch (ConfigurationException e) { + s_logger.warn("Unable to configure the storage ", e); + return null; + } + srs.put(storage, details); + + return srs; + } + + protected Map<ServerResource, Map<String, String>> createDummySecondaryStorageResource(long dcId, Long podId, URI uri) { + Map<ServerResource, Map<String, String>> srs = new HashMap<ServerResource, Map<String, String>>(); + + DummySecondaryStorageResource storage = new DummySecondaryStorageResource(_useServiceVM); + storage = ComponentContext.inject(storage); + + Map<String, String> details = new HashMap<String, String>(); + + details.put("mount.path", uri.toString()); + details.put("orig.url", uri.toString()); + + Map<String, Object> params = new HashMap<String, Object>(); + params.putAll(details); + params.put("zone", Long.toString(dcId)); + if (podId != null) { + params.put("pod", podId.toString()); + } + params.put("guid", uri.toString()); + + try { + storage.configure("Storage", params); + } catch (ConfigurationException e) { + s_logger.warn("Unable to configure the storage ", e); + return null; + } + srs.put(storage, details); + + return srs; + } + + @Override + public boolean configure(String name, Map<String, Object> params) throws ConfigurationException { + super.configure(name, params); + + _mountParent = _params.get("mount.parent"); + if (_mountParent == null) { + _mountParent = "/mnt"; + } + + String useServiceVM = _params.get("secondary.storage.vm"); + if ("true".equalsIgnoreCase(useServiceVM)){ + _useServiceVM = true; + } + return true; + } + + @Override + public boolean matchHypervisor(String hypervisor) { + if( hypervisor.equals("SecondaryStorage")) { + return true; + } else { + return false; + } + } + + @Override + public Hypervisor.HypervisorType getHypervisorType() { + return Hypervisor.HypervisorType.None; + } + + @Override + public void postDiscovery(List<HostVO> hosts, long msId) { + if (_useServiceVM) { + for (HostVO h: hosts) { + _agentMgr.agentStatusTransitTo(h, Event.AgentDisconnected, msId); + } + } + for (HostVO h: hosts) { + associateTemplatesToZone(h.getId(), h.getDataCenterId()); + } + + } + + private void associateTemplatesToZone(long hostId, long dcId){ + VMTemplateZoneVO tmpltZone; + + List<VMTemplateVO> allTemplates = _vmTemplateDao.listAll(); + for (VMTemplateVO vt: allTemplates){ + if (vt.isCrossZones()) { + tmpltZone = _vmTemplateZoneDao.findByZoneTemplate(dcId, vt.getId()); + if (tmpltZone == null) { + VMTemplateZoneVO vmTemplateZone = new VMTemplateZoneVO(dcId, vt.getId(), new Date()); + _vmTemplateZoneDao.persist(vmTemplateZone); + } + } + } + } +}
