Jugen opened a new pull request, #610: URL: https://github.com/apache/cayenne/pull/610
The current implementation has three problems: 1. It fails when a column has an alias 2. It builds the whole SQL column string before comparing 3. It doesn't seem very robust in preventing false results This PR replaces the current implementation with a visitor pattern that fails fast. The visitor extracts each node's parts into a List which is progressively compared to the parts extracted from the order node. Each item must match in position and content in both lists for them to match and will abort comparing as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cayenne.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
