stariy95 commented on code in PR #609:
URL: https://github.com/apache/cayenne/pull/609#discussion_r1500301392
##########
cayenne/src/main/java/org/apache/cayenne/exp/parser/ASTCustomAggregateFunctionCall.java:
##########
@@ -0,0 +1,34 @@
+package org.apache.cayenne.exp.parser;
+
+import org.apache.cayenne.exp.Expression;
+
+/**
+ * Class for custom aggregation functions expressions.
+ * @since 5.0
+ */
+public class ASTCustomAggregateFunctionCall extends ASTAggregateFunctionCall {
Review Comment:
I think we could shorten name of this class to just `ASTCustomAggregate`
##########
cayenne/src/main/java/org/apache/cayenne/exp/parser/ExpressionParserTreeConstants.java:
##########
@@ -64,6 +64,7 @@ public interface ExpressionParserTreeConstants
public int JJTDBPATH = 58;
public int JJTENUM = 59;
public int JJTDBIDPATH = 60;
+ public int JJTCUSTOMAGGREGATE = 61;
Review Comment:
It is better to leave generation of this constants to JavaCC and just leave
0 as a new AST node id for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
