[ 
https://issues.apache.org/jira/browse/CAY-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16418911#comment-16418911
 ] 

ASF GitHub Bot commented on CAY-2416:
-------------------------------------

GitHub user const1993 reopened a pull request:

    https://github.com/apache/cayenne/pull/279

    CAY-2416

    Maps optimization. Changed sorted maps to hash maps to improve performance.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/const1993/cayenne feature/CAY-2416

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cayenne/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit 36322d2953fe6469ded4fcf63005f9f78760ca56
Author: kkomyak <const1993@...>
Date:   2018-03-27T06:29:59Z

    CAY-2416
    Maps optimization. Changed sorted maps to hash maps to improve performance.

commit 8462e6f15f0e1daf4d6e0aadfe5f626c67b5d919
Author: kkomyak <const1993@...>
Date:   2018-03-28T08:26:44Z

    CAY-2416
    Added sorting of dbAttributes convert to xml.

commit 587997fe4a0ba94325c3ecb90f1a86708f61a826
Author: kkomyak <const1993@...>
Date:   2018-03-28T08:26:44Z

    CAY-2416
    Fixed build errors - added sorting of db entities in SchemaBuilder.

----


> Change TreeMap for HashMap to store data in Cayenne model classes
> -----------------------------------------------------------------
>
>                 Key: CAY-2416
>                 URL: https://issues.apache.org/jira/browse/CAY-2416
>             Project: Cayenne
>          Issue Type: Improvement
>          Components: Core Library, Modeler, Non-GUI Tools
>            Reporter: Nikita Timofeev
>            Assignee: Nikita Timofeev
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.1.M2
>
>
> Cayenne uses {{TreeMap}} internally to keep all model-related entities sorted 
> (Entities, Attributes, Relationships, etc.)
> But eventually ordering is needed only for tools (e.g. Modeler), while in 
> runtime it only creates unnecessary performance overhead.
> So we can use {{HashMap}} for runtime and sort data explicitly where it is 
> really needed (project saving, UI, etc.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to