[ https://issues.apache.org/jira/browse/CAY-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pengyu Nie updated CAY-2413: ---------------------------- Description: We found this task where the condition satisfied but action was not taken: cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/naming/DeduplicationVisitor.java:43 {code:java} // TODO: swap inner classes for lambdas when we are on java 8{code} - The trigger: "when we are on java 8" happened around commit <b332610abdc3e4f0ec7743982c6f3c84b3436dde> (Aug 18 2017). - But the action: "swap inner classes for lambdas" never happened since then. - What need to be done: replace the inner classes, mostly {code:java} new Predicate(){...}{code} with lambdas introduced in Java 8. was: We're working on a technique to automatically detecting unresolved trigger-action todo comments in codebase. Here is what we found in this project: cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/naming/DeduplicationVisitor.java:43 {code:java} // TODO: swap inner classes for lambdas when we are on java 8{code} - The trigger: "when we are on java 8" happened around commit <b332610abdc3e4f0ec7743982c6f3c84b3436dde> (Aug 18 2017). - But the action: "swap inner classes for lambdas" never happened since then. - What need to be done: replace the inner classes, mostly {code:java}new Predicate(){...}{code} with lambdas introduced in Java 8. > Found one unresolved task: DeduplicationVisitor "swap inner classes for > lambdas when we are on java 8" > ------------------------------------------------------------------------------------------------------ > > Key: CAY-2413 > URL: https://issues.apache.org/jira/browse/CAY-2413 > Project: Cayenne > Issue Type: Improvement > Components: Core Library > Reporter: Pengyu Nie > Assignee: Nikita Timofeev > Priority: Major > Fix For: 4.1.M2 > > > We found this task where the condition satisfied but action was not taken: > cayenne-dbsync/src/main/java/org/apache/cayenne/dbsync/naming/DeduplicationVisitor.java:43 > {code:java} > // TODO: swap inner classes for lambdas when we are on java 8{code} > > - The trigger: "when we are on java 8" happened around commit > <b332610abdc3e4f0ec7743982c6f3c84b3436dde> (Aug 18 2017). > - But the action: "swap inner classes for lambdas" never happened since then. > - What need to be done: replace the inner classes, mostly > {code:java} > new Predicate(){...}{code} > with lambdas introduced in Java 8. -- This message was sent by Atlassian JIRA (v7.6.3#76005)