[
https://issues.apache.org/jira/browse/CAY-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279638#comment-16279638
]
ASF GitHub Bot commented on CAY-2385:
-------------------------------------
GitHub user emecas opened a pull request:
https://github.com/apache/cayenne/pull/251
CAY-2385 CAY-2386 Fixing visualization issues after an undo action for a
deleted DbRelationship or DbAttribute
Includes solution for both bugs
[CAY-2385](https://issues.apache.org/jira/browse/CAY-2385) and
[CAY-2386](https://issues.apache.org/jira/browse/CAY-2386), as well as the
required refactoring derived from the solutions for
[CY-2379](https://issues.apache.org/jira/browse/CAY-2379) and
[CAY-2383](https://issues.apache.org/jira/browse/CAY-2383)
No bugs detected for `Embeddable` undo actions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emecas/cayenne CAY-2385_CAY-2386
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cayenne/pull/251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #251
----
commit 2d0daeeaf9c4d60b59d6a309a4f2462cb5f084ed
Author: Emerson Castaneda <eme...@users.noreply.github.com>
Date: 2017-12-02T03:39:10Z
CAY-2385 CAY-2386 Fixed visualization issues after an undo action for
deleted DbRelationship and DbAttribute
commit f181099ba03f61308aa0b055147f22d7c055f534
Author: Emerson Castaneda <eme...@users.noreply.github.com>
Date: 2017-12-02T04:04:08Z
CAY-2385 CAY-2386 Refactored 3 duplicated methods by moving these to their
correspondent superclasses
commit a941ea7b0d6518ea6e90bee4b57c2f142633b790
Author: Emerson Castaneda <eme...@users.noreply.github.com>
Date: 2017-12-02T04:15:26Z
CAY-2385 CAY-2386 Refactored 1 duplicated method by moving it to their
correspondent superclass
----
> Modeler: Visualization issue after an undo action for a deleted DbRelationship
> ------------------------------------------------------------------------------
>
> Key: CAY-2385
> URL: https://issues.apache.org/jira/browse/CAY-2385
> Project: Cayenne
> Issue Type: Bug
> Components: Modeler
> Affects Versions: 4.1.M1
> Reporter: Emerson Castaneda
> Assignee: Nikita Timofeev
> Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.B3, 4.1.M2
>
>
> Description:
> Modeler misbehaves during an undo action for a DbEntity
> How to reproduce:
> Precondition: In a project with at least 2 DbEntities, DbEntity1 and
> DbEntity2, with ObjRelationship and ObjAttribute in their lists.
> 1. Go to DbEntity1 and remove an existent DbRelationship
> 2. Switch to the DbEntity2 to visualize its attribute(s) and relation(s)
> 3. Go to main menu and select undo
> 4. Visualized DbAttribute(s) list is incorrect, modeler only refresh the
> DbRelationship(s) list
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
