(causeway) branch v4 updated: CAUSEWAY-3901: reverts conditional auto sizing de-activation

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch v4
in repository https://gitbox.apache.org/repos/asf/causeway.git


The following commit(s) were added to refs/heads/v4 by this push:
     new 529057d8f75 CAUSEWAY-3901: reverts conditional auto sizing 
de-activation
529057d8f75 is described below

commit 529057d8f750a2583b5df8edd1aca5432074ef6a
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Fri Aug 29 06:42:11 2025 +0200

    CAUSEWAY-3901: reverts conditional auto sizing de-activation
    
    - turns out, has not that much of a performance impact
    - however, we keep the logging part
---
 .../tabular/excel/exporter/ExcelFileWriter.java           | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git 
a/extensions/vw/tabular/excel/src/main/java/org/apache/causeway/extensions/tabular/excel/exporter/ExcelFileWriter.java
 
b/extensions/vw/tabular/excel/src/main/java/org/apache/causeway/extensions/tabular/excel/exporter/ExcelFileWriter.java
index fd89a8f6b81..e45977c5b76 100644
--- 
a/extensions/vw/tabular/excel/src/main/java/org/apache/causeway/extensions/tabular/excel/exporter/ExcelFileWriter.java
+++ 
b/extensions/vw/tabular/excel/src/main/java/org/apache/causeway/extensions/tabular/excel/exporter/ExcelFileWriter.java
@@ -162,7 +162,6 @@ private void writeSheet(final Workbook wb, final 
TabularModel.TabularSheet tabul
 
         var dataRows = tabularSheet.rows();
 
-        var isLarge = dataRows.size()>=10000;
         int writtenCount = 0;
 
         // detail rows
@@ -181,19 +180,17 @@ private void writeSheet(final Workbook wb, final 
TabularModel.TabularSheet tabul
                 maxLinesInRow.accept(linesWritten);
             }
             cellStyleProvider.applyCustomStyle(dataRow, row);
-            ++writtenCount;
 
-            if(!isLarge) {
-                autoSizeRow(row, maxLinesInRow.getResult().orElse(1), null);
-            } else if(writtenCount%1000==0) {
+            autoSizeRow(row, maxLinesInRow.getResult().orElse(1), null);
+
+            ++writtenCount;
+            if(writtenCount%1000==0) {
                 log.info("rows written {}k of {}k", writtenCount/1000, 
(dataRows.size()+500)/1000);
             }
         }
 
-        if(!isLarge) {
-            // column auto-size
-            autoSizeColumns(sheet, dataColumns.size());
-        }
+        // column auto-size
+        autoSizeColumns(sheet, dataColumns.size());
 
         // freeze panes
         sheet.createFreezePane(0, 2);