[ 
https://issues.apache.org/jira/browse/CASSANDRA-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081306#comment-14081306
 ] 

Aleksey Yeschenko commented on CASSANDRA-7311:
----------------------------------------------

[~mishraawake] sorry for the delay. The patch itself looks good to me, 
code-wise, aside from very minor code-style issues (\{ w/out a newline and some 
extra whitespace, nothing serious).

It does seem however that it's a better option overall to have this particular 
setting global and not per-table (see Brandon's and Jeremiah's comments).

So I'm going to resolve this one as 'Not a Problem', but please don't let it 
discourage you from contributing in the future (and once again, sorry for my 
delay in reviewing this).

> Enable incremental backup on a per-keyspace level
> -------------------------------------------------
>
>                 Key: CASSANDRA-7311
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7311
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Johnny Miller
>            Assignee: pankaj mishra
>            Priority: Minor
>              Labels: lhf
>         Attachments: 7311-cqlsh-update.txt, cassandra-rebased-2.1.patch, 
> table_incremental_7311.patch
>
>
> Currently incremental backups are globally defined, however this is not 
> always appropriate or required for all keyspaces in a cluster. 
> As this is quite expensive, it would be preferred to either specify the 
> keyspaces that need this (or exclude the ones that don't).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to