[ 
https://issues.apache.org/jira/browse/CASSANDRA-6993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976537#comment-13976537
 ] 

Benedict commented on CASSANDRA-6993:
-------------------------------------

1) isUnix should be "final"
2) I think your "isUnix" check is too limited: this will break Mac OSX, FreeBSD 
and Solaris users, possibly others. Since basically every OS other than Windows 
probably supports this, I'd suggest making it an "isWindows" check and looking 
for contains("windows"). [This 
link|http://mindprod.com/jgloss/properties.html#OSNAME] may help, although may 
not be completely authoritative. A quick grep of openjdk shows the following 
line in their own test tools, though: 

{code}
static boolean isWindows = System.getProperty("os.name").startsWith("Windows");
{code}

Which suggests it's probably sufficient.

> Windows: remove mmap'ed I/O for index files and force standard file access
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6993
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6993
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 6993_v1.txt
>
>
> Memory-mapped I/O on Windows causes issues with hard-links; we're unable to 
> delete hard-links to open files with memory-mapped segments even using nio.  
> We'll need to push for close to performance parity between mmap'ed I/O and 
> buffered going forward as the buffered / compressed path offers other 
> benefits.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to