[ 
https://issues.apache.org/jira/browse/CASSANDRA-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569458#comment-13569458
 ] 

Jonathan Ellis commented on CASSANDRA-4554:
-------------------------------------------

Good idea using a UUID time period to avoid needing an explicit reset method.

We might want to move that to a separate table so observers can ask for "are 
there any new entries since the last one I observed?" instead of having to poll 
the entire collection and diff manually with what it's already 
seen-and-alerted.  Thoughts, [~thobbs]?

Nits:

- updateHintsDropped parameter name would better named timePeriod than 
columnName
- brace on same line in shouldHint
                
> Log when a node is down longer than the hint window and we stop saving hints
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4554
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4554
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 1.2.2
>
>         Attachments: 0001-CASSANDRA-4554-add-hint-metrics.patch, 
> 0001-CASSANDRA-4554-logging-to-system-table-v2.patch, 
> 0001-CASSANDRA-4554-v3.patch, 
> 0002-CASSANDRA-4554-logging-to-system-table.patch, 4554.patch
>
>
> We know that we need to repair whenever we lose a node or disk permanently 
> (since it may have had undelivered hints on it), but without exposing this we 
> don't know when nodes stop saving hints for a temporarily dead node, unless 
> we're paying very close attention to external monitoring.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to