[
https://issues.apache.org/jira/browse/CASSANDRA-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460584#comment-13460584
]
Jonathan Ellis commented on CASSANDRA-4697:
-------------------------------------------
If we switch to explicitly calling a method, we need to add a "if
logger.isDebugEnabled" wrapper, otherwise the method call gets evaluated
unnecessarily.
But why is ArrayList.toString not being invoked?
> incorrect debug message in LeveledManifest.java
> -----------------------------------------------
>
> Key: CASSANDRA-4697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4697
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.11, 1.1.5
> Reporter: Radim Kolar
> Priority: Trivial
>
> https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/LeveledManifest.java
> line 622.
> logger.debug("Estimating {} compactions to do for {}.{}",
> new Object[] {Arrays.asList(estimated), cfs.table.name, cfs.columnFamily});
> It does not print list as intended. Arrays.asList(estimated).toString()
> results in object reference number, not list itself making debug message
> useless.
> list should be printed by code like this:
> String delim = "";
> for (Item i : list) {
> sb.append(delim).append(i);
> delim = ",";
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
