[
https://issues.apache.org/jira/browse/CASSANDRA-21658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18115724#comment-18115724
]
Michael Semb Wever commented on CASSANDRA-21658:
------------------------------------------------
CI results.
*{{mck/CASSANDRA-21658/5.0}}*: UNSTABLE, [cassandra-5.0
#18|https://astro-cass.ci/job/cassandra-5.0/18] at
[2bfa54bc89f4|https://github.com/thelastpickle/cassandra/commit/2bfa54bc89f4f0cd039a122bc8a25a9128563fd6],
profile pre-commit w/ upgrades. Passed 55590 – Failed 4 – Skipped 3180 –
Total 58774. 4 failures,
* unproven, 3 failures:
[dtest-novnode.repair_tests.repair_test.TestRepair.test_wide_row_repair_lcs|https://astro-cass.ci/job/cassandra-5.0/18/testReport/dtest-novnode.repair_tests.repair_test/TestRepair/]
(2 times),
[dtest-novnode.transient_replication_ring_test.TestTransientReplicationRing.test_move_forwards_between_and_cleanup|https://astro-cass.ci/job/cassandra-5.0/18/testReport/dtest-novnode.transient_replication_ring_test/TestTransientReplicationRing/]
* known, 1 failure:
[simulator.test.ShortPaxosSimulationTest.simulationTest|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-5.0/failure/org.apache.cassandra.simulator.test/ShortPaxosSimulationTest/simulationTest]
(CASSANDRA-19280)
Cassandra-5.0 recent failure counts: #634 7, #635 8, #636 0, #637 15, #638 7.
*{{mck/CASSANDRA-21658/6.0}}*: UNSTABLE, [cassandra-6.0
#25|https://astro-cass.ci/job/cassandra-6.0/25] at
[86c2c568e5fd|https://github.com/thelastpickle/cassandra/commit/86c2c568e5fda8c3b9e2ec5018acd56bc960d95b],
profile pre-commit w/ upgrades. Passed 113882 – Failed 17 – Skipped 2912 –
Total 116811. 17 failures,
* unproven, 9 failures:
[distributed.test.repair.AutoRepairSchedulerDisallowParallelReplicaRepairAcrossSchedulesTest.testScheduler|https://astro-cass.ci/job/cassandra-6.0/25/testReport/org.apache.cassandra.distributed.test.repair/AutoRepairSchedulerDisallowParallelReplicaRepairAcrossSchedulesTest/]
(2 times),
[dtest-novnode.pushed_notifications_test.TestPushedNotifications.test_move_single_node_localhost|https://astro-cass.ci/job/cassandra-6.0/25/testReport/dtest-novnode.pushed_notifications_test/TestPushedNotifications/],
[dtest-novnode.repair_tests.repair_test.TestRepair.test_wide_row_repair_lcs|https://astro-cass.ci/job/cassandra-6.0/25/testReport/dtest-novnode.repair_tests.repair_test/TestRepair/],
[dtest-upgrade.upgrade_tests.cql_tests.TestCQLNodes2RF1_Upgrade_indev_4_0_x_To_indev_6_0_x.test_dynamic_cf|https://astro-cass.ci/job/cassandra-6.0/25/testReport/dtest-upgrade.upgrade_tests.cql_tests/TestCQLNodes2RF1_Upgrade_indev_4_0_x_To_indev_6_0_x/],
[junit.framework.TestSuite.org.apache.cassandra.distributed.test.repair.AutoRepairSchedulerDisallowParallelReplicaRepairAcrossSchedulesTest|https://astro-cass.ci/job/cassandra-6.0/25/testReport/org.apache.cassandra.distributed.test.repair/AutoRepairSchedulerDisallowParallelReplicaRepairAcrossSchedulesTest/]
(2 times),
[simulator.test.ShortAccordSimulationTest.simulationTest|https://astro-cass.ci/job/cassandra-6.0/25/testReport/org.apache.cassandra.simulator.test/ShortAccordSimulationTest/],
[simulator.test.ShortPaxosSimulationTest.selfReconcileTest|https://astro-cass.ci/job/cassandra-6.0/25/testReport/org.apache.cassandra.simulator.test/ShortPaxosSimulationTest/]
* flaky, 7 failures:
[distributed.test.accord.InteropAccordCQLTest.testCASSimulatorLite|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-6.0/failure/org.apache.cassandra.distributed.test.accord/InteropAccordCQLTest/testCASSimulatorLite]
(3 times),
[simulator.test.AccordHarrySimulationTest.test|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-6.0/failure/org.apache.cassandra.simulator.test/AccordHarrySimulationTest/test],
[simulator.test.EpochStressTest.manyEpochsAndAccordConverges|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-6.0/failure/org.apache.cassandra.simulator.test/EpochStressTest/manyEpochsAndAccordConverges],
[simulator.test.SingleNodeSingleTableASTTest.accordFull|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-6.0/failure/org.apache.cassandra.simulator.test/SingleNodeSingleTableASTTest/accordFull],
[simulator.test.SingleNodeSingleTableASTTest.accordMixedReads|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-6.0/failure/org.apache.cassandra.simulator.test/SingleNodeSingleTableASTTest/accordMixedReads]
* known, 1 failure:
[distributed.upgrade.MixedModeMessageForwardTest.checkWritesForwardedToOtherDcTest|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-6.0/failure/org.apache.cassandra.distributed.upgrade/MixedModeMessageForwardTest/checkWritesForwardedToOtherDcTest]
(CASSANDRA-18690)
Cassandra-6.0 recent failure counts: #87 25, #88 20, #89 38, #90 19, #139 30.
*{{mck/CASSANDRA-21658/trunk}}*: UNSTABLE, [cassandra
#26|https://astro-cass.ci/job/cassandra/26] at
[88fb771102e8|https://github.com/thelastpickle/cassandra/commit/88fb771102e80ab4b382f78777cee818c1a20984],
profile pre-commit w/ upgrades. Passed 114120 – Failed 10 – Skipped 2394 –
Total 116524. 10 failures,
* unproven, 4 failures:
[dtest-novnode.repair_tests.repair_test.TestRepair.test_wide_row_repair_lcs|https://astro-cass.ci/job/cassandra/26/testReport/dtest-novnode.repair_tests.repair_test/TestRepair/],
[fuzz.sai.AccordFullSingleNodeSAITest.indexOnlySaiTest|https://astro-cass.ci/job/cassandra/26/testReport/org.apache.cassandra.fuzz.sai/AccordFullSingleNodeSAITest/],
[simulator.test.ShortAccordSimulationTest.simulationTest|https://astro-cass.ci/job/cassandra/26/testReport/org.apache.cassandra.simulator.test/ShortAccordSimulationTest/],
[simulator.test.ShortPaxosSimulationTest.selfReconcileTest|https://astro-cass.ci/job/cassandra/26/testReport/org.apache.cassandra.simulator.test/ShortPaxosSimulationTest/]
* flaky, 6 failures:
[db.compaction.UnifiedCompactionStrategyTest.testDropExpiredSSTables|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/org.apache.cassandra.db.compaction/UnifiedCompactionStrategyTest/testDropExpiredSSTables],
[distributed.test.accord.InteropAccordCQLTest.testCASSimulatorLite|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/org.apache.cassandra.distributed.test.accord/InteropAccordCQLTest/testCASSimulatorLite],
[simulator.test.AccordHarrySimulationTest.test|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/org.apache.cassandra.simulator.test/AccordHarrySimulationTest/test],
[simulator.test.EpochStressTest.manyEpochsAndAccordConverges|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/org.apache.cassandra.simulator.test/EpochStressTest/manyEpochsAndAccordConverges],
[simulator.test.SingleNodeSingleTableASTTest.accordFull|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/org.apache.cassandra.simulator.test/SingleNodeSingleTableASTTest/accordFull],
[simulator.test.SingleNodeSingleTableASTTest.accordMixedReads|https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-trunk/failure/org.apache.cassandra.simulator.test/SingleNodeSingleTableASTTest/accordMixedReads]
Cassandra-trunk recent failure counts: #2549 58, #2550 34, #2551 38, #2553 0,
#2555 29.
Attached: [^ci_summary_thelastpickle_mck-CASSANDRA-21658-5.0_18.html],
[^results_details_thelastpickle_mck-CASSANDRA-21658-5.0_18.tar.xz],
[^ci_summary_thelastpickle_mck-CASSANDRA-21658-6.0_25.html],
[^results_details_thelastpickle_mck-CASSANDRA-21658-6.0_25.tar.xz],
[^ci_summary_thelastpickle_mck-CASSANDRA-21658-trunk_26.html],
[^results_details_thelastpickle_mck-CASSANDRA-21658-trunk_26.tar.xz]
> A read on a replica that does not know the index yet fails with a
> NullPointerException
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-21658
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21658
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Feature/2i Index
> Reporter: Michael Semb Wever
> Priority: Normal
> Fix For: 5.0.x, 6.0.x, 7.x
>
> Attachments:
> ci_summary_thelastpickle_mck-CASSANDRA-21658-5.0_18.html,
> ci_summary_thelastpickle_mck-CASSANDRA-21658-6.0_25.html,
> ci_summary_thelastpickle_mck-CASSANDRA-21658-trunk_26.html,
> results_details_thelastpickle_mck-CASSANDRA-21658-5.0_18.tar.xz,
> results_details_thelastpickle_mck-CASSANDRA-21658-6.0_25.tar.xz,
> results_details_thelastpickle_mck-CASSANDRA-21658-trunk_26.tar.xz
>
>
> {{ReadCommand.Serializer.deserializeIndexMetadata}} returns null when the
> index the coordinator names is unknown to this replica, and says so:
> {code:java}
> logger.info("Couldn't find a defined index on {}.{} with the id {}. " +
> "If an index was just created, this is likely due to the schema
> not " +
> "being fully propagated. Local read will proceed without using
> the " +
> "index. ...");
> return null;
> {code}
> The caller passes that null straight on:
> {code:java}
> IndexMetadata index = deserializeIndexMetadata(in, version, metadata);
> Index.Group indexGroup =
> Keyspace.openAndGetStore(metadata).indexManager.getIndexGroup(index);
> {code}
> {{SecondaryIndexManager.getIndexGroup}} calls {{getIndex}}, which reads
> {{metadata.name}}, so the local read does not proceed at all: deserialization
> throws a NullPointerException, the message is dropped, and the coordinator
> waits for the read to time out. The window is the schema propagation of a new
> index, so a client sees read timeouts for a short time after {{CREATE INDEX}}.
> The patch tests the index metadata for null, so the read proceeds without the
> index as the log line states, and marks {{deserializeIndexMetadata}}
> {{Nullable}} together with the two {{SecondaryIndexManager}} methods that
> require an index.
> Patch:
> [mck/CASSANDRA-21658/5.0|https://github.com/thelastpickle/cassandra/tree/mck/CASSANDRA-21658/5.0]
> Provenance:
> [69d5b5a300|https://github.com/datastax/cassandra/commit/69d5b5a300d2c82a83713191b4a8ed29c2dd5e04]
> by Piotr Kołaczkowski, [~cassandra-te]. That commit is the same change; this
> patch adds the regression test it lacks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
