[
https://issues.apache.org/jira/browse/CASSANDRA-21552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18105368#comment-18105368
]
Paulo Motta commented on CASSANDRA-21552:
-----------------------------------------
> Forced repair is something like "I am impatient and I want to repair right
> now or there is an urgency", not "just keep repairing until you succeed".
Makes sense, as long as we document it properly in CHANGES.txt or NEWS.txt
> Can you elaborate why do you want to clear forced repair flag only on forced
> repair?
I just thought this field was not set for standard repairs, now it will be set
for all repairs as false. Also if a normal repair is running and the operator
enable a forced repair, that will be cleared when the normal repair fininshes.
Both are not a big deal but just worth noting.
> Force repair should ignore min_repair_interval
> ----------------------------------------------
>
> Key: CASSANDRA-21552
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21552
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Feature/Repair
> Reporter: Tommy Stendahl
> Assignee: Tommy Stendahl
> Priority: Normal
> Fix For: 5.0.x, 6.x, 7.x
>
> Attachments: ci_summary_driftx_CASSANDRA-21552-5.0_184.html,
> ci_summary_driftx_CASSANDRA-21552-6.0_113.html,
> ci_summary_driftx_CASSANDRA-21552-trunk_665.html,
> results_details_driftx_CASSANDRA-21552-5.0_184.tar.xz,
> results_details_driftx_CASSANDRA-21552-6.0_113.tar.xz,
> results_details_driftx_CASSANDRA-21552-trunk_665.tar.xz
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> If you set force repair for a node the repair is not triggered until
> min_repair_interval has expired, this could be several hours. This seams like
> a mistake, if you need to do a force repair you probably want it executed
> ASAP regardless of min_repair_interval.
> The problem is that in AutoRepair.java, tooSoonToRunRepair() is called before
> myTurnToRunRepair(). Since tooSoonToRunRepair() checks if min_repair_interval
> has elapsed and returns early if it hasn't, a node with force_repair set is
> still blocked from triggering immediate repair.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
