[ 
https://issues.apache.org/jira/browse/CASSANDRA-21527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18104875#comment-18104875
 ] 

Caleb Rackliffe commented on CASSANDRA-21527:
---------------------------------------------

Alright, aside from a couple nits on import order for {{InboundSink}} in the 
4.0 and 5.0 branches, all branches looks good to me. We should be good to 
commit after a quick audit of the CI results...

> truncateBlocking silently succeeds when runWithCompactionsDisabled returns 
> null
> -------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-21527
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21527
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Legacy/Core
>            Reporter: Nivy Kani
>            Assignee: Nivy Kani
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.0.x, 6.x, 7.x
>
>         Attachments: 4.0-ci_summary.html, 4.0-result_details.tar.gz, 
> 4.1-ci_summary.html, 4.1-result_details.tar.gz, 5.0-ci_summary.html, 
> 5.0-result_details.tar.gz, 6.0-ci_summary.html, 6.0-result_details.tar.gz, 
> ci_summary-1.html, result_details.tar-1.gz
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> Currently, runWithCompactionsDisabled can’t tell the difference between a 
> successful truncate vs a truncate that wasn’t successful due to being unable 
> to stop compaction, because both return null. In either case, it logs 
> “Truncate is complete” and returns success to the user. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to