[
https://issues.apache.org/jira/browse/CASSANALYTICS-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18103471#comment-18103471
]
Saranya Krishnakumar commented on CASSANALYTICS-191:
----------------------------------------------------
+1
> CDC reader stats silently dropped in SidecarCdcBuilder
> ------------------------------------------------------
>
> Key: CASSANALYTICS-191
> URL: https://issues.apache.org/jira/browse/CASSANALYTICS-191
> Project: Apache Cassandra Analytics
> Issue Type: Improvement
> Components: CDC
> Reporter: Jyothsna Konisa
> Assignee: Jyothsna Konisa
> Priority: Normal
> Fix For: 0.5
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SidecarCdcBuilder's constructor accepts an ICdcStats cdcStats parameter, but
> never assigns it to this.stats or calls withStats(cdcStats). CdcBuilder's own
> constructor (the superclass) also never sets stats — the field stays at its
> declaration default, ICdcStats stats = ICdcStats.STUB (a no-op anonymous
> implementation).
> As a result, every Cdc/SidecarCdc instance built via SidecarCdc.builder(...)
> uses ICdcStats.STUB internally, regardless of what stats implementation the
> caller supplies. All ICdcStats calls made from CdcScannerBuilder,
> MicroBatchIterator, and BufferingCommitLogReader (produced/received latency,
> mutations read, dropped/corrupt mutations, watermarker size,
> insufficient-replicas, late-publish, commit-log read timing, etc.) execute
> against the no-op stub and never reach the caller's real implementation.
> Since the interface's default methods have empty bodies, this produces zero
> errors, zero log output, and zero indication anything is wrong.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
