[
https://issues.apache.org/jira/browse/CASSANDRA-21462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18102233#comment-18102233
]
Dmitry Konstantinov commented on CASSANDRA-21462:
-------------------------------------------------
Hi [~rustyrazorblade]
I'm currently reviewing the MR, and I have two general requests:
# Would it be possible to run the newly added test suite and share both the
execution time per test and the total execution time? This would help us
understand the impact on the overall CI runtime and determine whether some of
the tests should be moved to the "long" test category.
# As expected, these tests perform a significant amount of disk I/O, and the
current implementation relies on temporary directories for cleanup. We've
recently had several CI stability issues caused by excessive disk space
consumption, with builds failing because CI agents ran out of disk space. Would
it be possible to adjust the test logic to clean up generated files as soon as
they are no longer needed, rather than waiting until the temporary directory is
removed at the end?
> Add byte for byte test harness to detect and resolve cursor deviations from
> iterator path
> -----------------------------------------------------------------------------------------
>
> Key: CASSANDRA-21462
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21462
> Project: Apache Cassandra
> Issue Type: Sub-task
> Components: Local/Compaction
> Reporter: Jon Haddad
> Assignee: Jon Haddad
> Priority: High
> Fix For: 6.0
>
>
> This issue addresses various deviations and inconsistencies with the cursor
> path by introducing tests that verify both the old iterator path and the new
> cursor path generate the same outputs given the same inputs. It also fixes
> various issues found in the process of creating this test system that
> resulted in corruption or incorrect values being carried into the resulting
> SSTable.
> It adds a test that uses the JVM's internal memory tracking to assert that we
> do NOT do unnecessary allocations in the cursor path that should guard
> against future regressions, and fixes an unnecessary enum allocation.
> It does NOT add support for BTI, multi-cell columns, counters, etc.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
