SiyaoIsHiding commented on PR #440: URL: https://github.com/apache/cassandra-nodejs-driver/pull/440#issuecomment-5171958539
`ControlConnection.shutdown()` is only called in `client.shutDown()`, and when a user wants to shut down a client, I believe we don't want the refresh to happen at all, regardless of whether it blocks the event loop or not. So I think we should `clearTimeout` instead of `unref()` on this one, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
