[
https://issues.apache.org/jira/browse/CASSANDRA-14366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100363#comment-18100363
]
Stefan Miklosovic edited comment on CASSANDRA-14366 at 7/30/26 9:37 AM:
------------------------------------------------------------------------
[~arvindk12] could you please add a test which tests that these values are
actually not 0 and preparing statement will actually increase the values? It
might look like an overkill but without a test I can not approve it actually
does the thing. The pattern you used in tests will match all values to be zero,
there is no proof the values actually increase and they reflect what they say
they do in the nodetool command.
You do not need to check exact numbers for evictions or size, just check the
size is bigger than zero, leave evictions be.
was (Author: smiklosovic):
[~arvindk12] could you please add a test which tests that these values are
actually not 0 and preparing statement will actually increase the values? It
might look like an overkill but without a test I can not approve it actually
does the thing. The pattern you used in tests will match all values to be zero,
there is no proof the values actually increase and they reflect what they say
they do in the nodetool command.
> Add prepared statement cache stats to nodetool info
> ---------------------------------------------------
>
> Key: CASSANDRA-14366
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14366
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics, Tool/nodetool
> Reporter: Jon Haddad
> Assignee: Arvind Kandpal
> Priority: Normal
> Fix For: 7.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We expose some cache stats in {{nodetool info}}, let's add prepared statement
> cache stats.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
