[ 
https://issues.apache.org/jira/browse/CASSANDRA-19985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099019#comment-18099019
 ] 

Brad Schoening edited comment on CASSANDRA-19985 at 7/24/26 9:16 PM:
---------------------------------------------------------------------

[~arvindk12]  I've just taken a look and overall looks quite good.  One small 
issue:

with select * from system.compaction_history,
{code:java}
  {"id": "b6501d90-8195-11f1-86f0-f7138403cdcf", "bytes_in": "14413", 
"bytes_out": "3268", "columnfamily_name": "size_estimates", "compacted_at": 
"2026-07-17 04:12:23.556000+0000", "compaction_properties": 
"{'compaction_type': 'Compaction'}", "keyspace_name": "system", "rows_merged": 
"{4: 3}"}{code}
the bigint value in Json is formatted with quotes on the values but should be 
just ints:
{noformat}
"bytes_in": 0,
"bytes_out": 0
{noformat}
 

same is true for null:
{noformat}
"rows_merged": null{noformat}
please add or update the unit tests to match


was (Author: bschoeni):
[~arvindk12]  I've just taken a look and one small issue:

with select * from system.compaction_history,
{code:java}
  {"id": "b6501d90-8195-11f1-86f0-f7138403cdcf", "bytes_in": "14413", 
"bytes_out": "3268", "columnfamily_name": "size_estimates", "compacted_at": 
"2026-07-17 04:12:23.556000+0000", "compaction_properties": 
"{'compaction_type': 'Compaction'}", "keyspace_name": "system", "rows_merged": 
"{4: 3}"}{code}
the bigint value in Json is formatted with quotes on the values but should be 
just ints:

 
{noformat}
"bytes_in": 0,
"bytes_out": 0
{noformat}
 

same is true for null:


{noformat}
"rows_merged": null{noformat}
please add or update the unit tests to match

> Enhance CQLSH to support machine-readable output formatting
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-19985
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19985
>             Project: Apache Cassandra
>          Issue Type: New Feature
>          Components: CQL/Interpreter
>            Reporter: Brad Schoening
>            Assignee: Arvind Kandpal
>            Priority: Normal
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Existing CQLSH output formatting provides tabular formatting using grid-like 
> separators and text alignment which is designed for user readability. 
> When CQL is run for non-interactive tasks as part of a pipeline this 
> formatting complicates the machine processing of the output. As an example, 
> [Sqlite|https://www.sqlite.org/cli.html] has a command line flag -mode to 
> switch between tablular, csv, and several other supported formats.
> This enhancement will provide a new mode argument which will initially offer 
> tabular and csv output formats. Tabular will remain the default so there will 
> be no change for existing users.  In the future, other modes such as json and 
> insert could be added.
> {noformat}
> --mode={tabular, csv}
> Specify an output display format. The default is tabular.
> {noformat}
> The existing Copy To can be used for exporting to CSV, but it doesn't allow 
> for query criteria and thus isn't a general solution for this issue.
> In cqlshmain.py, the EXPAND CQLSH option which uses print_formatted_result() 
> for result output is an example of alternative formatting.
> Paging will have to be properly managed. A good formatter should handle a 
> stream of rows rather than requiring the entire list in memory, especially 
> for large SELECT * queries.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to