jyothsnakonisa commented on code in PR #176:
URL:
https://github.com/apache/cassandra-analytics/pull/176#discussion_r2898197366
##########
cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/db/commitlog/BufferingCommitLogReader.java:
##########
@@ -427,6 +437,7 @@ private void readSection(FileDataInput reader,
if (serializedSize == LEGACY_END_OF_SEGMENT_MARKER)
{
logger.trace("Encountered end of segment marker at",
"position", reader.getFilePointer());
+ this.position = (int) log.maxOffset();
Review Comment:
Thanks for flagging this. This code gets executed only for legacy commit
logs (2.x version). I added a test to test this
`testPositionAtMaxOffsetInCommitlogsWithPaddedZeros`, but realized that I can't
produce a 2.x version commit log easily hence removed the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
