[
https://issues.apache.org/jira/browse/CASSANDRA-21199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063031#comment-18063031
]
Matt Byrd commented on CASSANDRA-21199:
---------------------------------------
Hmm the initial allocation profile in question might not have been when the
node was that busy .
On another one I'm seeing just 0.03% of allocations, maybe less
relevant/worthwhile but I suppose still little downside.
> ProtocolVersion::supportedVersions can be computed once to avoid showing up
> in allocation profiles
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-21199
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21199
> Project: Apache Cassandra
> Issue Type: Improvement
> Reporter: Matt Byrd
> Assignee: Matt Byrd
> Priority: Normal
> Attachments: Screenshot 2026-03-04 at 7.01.51 PM.png
>
>
> It's a relatively small amount in one allocation profile (see attached
> screenshot) ~0.3% of allocations, but still seems un-necessary as we're
> copying elements from a static final EnumSet
> {code}
> /** All supported versions, published as an enumset */
> public final static EnumSet<ProtocolVersion> SUPPORTED =
> EnumSet.copyOf(Arrays.asList(ArrayUtils.addAll(SUPPORTED_VERSIONS)));
> {code}
> Could instead just compute this in static initialization .
> {code}
> public static List<String> supportedVersions()
> {
> List<String> ret = new ArrayList<>(SUPPORTED.size());
> for (ProtocolVersion version : SUPPORTED)
> ret.add(version.toString());
> return ret;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
