[
https://issues.apache.org/jira/browse/CASSANDRA-21032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18038966#comment-18038966
]
Dmitry Konstantinov commented on CASSANDRA-21032:
-------------------------------------------------
[~ifesdjeen] Could you please help me understand the reason for this change? Do
we really need it?
> Test failure: TestClientRequestMetrics.test_client_request_metrics
> ------------------------------------------------------------------
>
> Key: CASSANDRA-21032
> URL: https://issues.apache.org/jira/browse/CASSANDRA-21032
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Observability/Metrics, Test/dtest/python
> Reporter: Dmitry Konstantinov
> Assignee: Dmitry Konstantinov
> Priority: Normal
> Fix For: 5.x
>
>
> TestClientRequestMetrics.test_client_request_metrics fail consistency on
> trunk.
> For example:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/2325/#showFailuresLink]
> {code:java}
> AssertionError:
> org.apache.cassandra.metrics:type=ClientRequest,scope=Write-ANY,name=LatencyMean
> assert 0.0 is None {code}
> {code}
> self = <client_request_metrics_test.TestClientRequestMetrics object at
> 0x7f5586135640>
> def test_client_request_metrics(self):
> # this is written as a single test method in order to reuse the same
> cluster for all tests
> # setup_once configures and starts the cluster with all schema and
> preconditions required by all tests.
> self.setup_once()
>
> > self.write_nominal()
> client_request_metrics_test.py:85:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> client_request_metrics_test.py:116: in write_nominal
> global_diff, cl_diff = self.validate_nominal('Write',
> client_request_metrics_test.py:148: in validate_nominal
> b.validate(cassandra_version)
> client_request_metrics_test.py:670: in validate
> v.validate(cassandra_version)
> client_request_metrics_test.py:652: in validate
> validate_stat_values(self.mbean, self.values, cassandra_version)
> client_request_metrics_test.py:596: in validate_stat_values
> validate_zero_histogram_values(prefix, values)
> client_request_metrics_test.py:629: in validate_zero_histogram_values
> validators[k](f"{prefix}{k}", v)
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> k =
> 'org.apache.cassandra.metrics:type=ClientRequest,scope=Write-ANY,name=LatencyMean'
> v = 0.0
> def is_none(k, v):
> > assert v is None, k
> E AssertionError:
> org.apache.cassandra.metrics:type=ClientRequest,scope=Write-ANY,name=LatencyMean
> E assert 0.0 is None
> client_request_metrics_test.py:767: AssertionError
> {code}
> {code}
> def validate_zero_histogram_values(prefix, values):
> validators = defaultdict(lambda: is_zero)
> validators['RecentValues'] = is_zero_list
> validators['Mean'] = is_none # <============== we fail here
> validators['DurationUnit'] = is_microseconds
> for k, v in values.items():
> validators[k](f"{prefix}{k}", v)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
