frankgh commented on code in PR #152:
URL:
https://github.com/apache/cassandra-analytics/pull/152#discussion_r2491431163
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/partitioner/CassandraInstance.java:
##########
@@ -34,20 +36,20 @@ public class CassandraInstance implements TokenOwner,
Serializable
public static final CassandraInstance.Serializer SERIALIZER = new
CassandraInstance.Serializer();
private static final long serialVersionUID = 6767636627576239773L;
- private final String token;
+ private final Set<String> tokens;
private final String node;
private final String dataCenter;
- public CassandraInstance(String token, String node, String dataCenter)
+ public CassandraInstance(Set<String> tokens, String node, String
dataCenter)
{
- this.token = token;
+ this.tokens = tokens;
Review Comment:
Let's validate non-null or empty here . i.e
```suggestion
this.tokens = Objects.requireNotNull(tokens, "tokens cannot be
null");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
