[
https://issues.apache.org/jira/browse/CASSANDRA-20874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017375#comment-18017375
]
Michael Semb Wever commented on CASSANDRA-20874:
------------------------------------------------
but a real problem here is it is only looking at the local build.xml
this isn't accurate when {{`-b`}} is specified
> .build/run-ci does not work for trunk
> --------------------------------------
>
> Key: CASSANDRA-20874
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20874
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Build, CI
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{jenkins-deployment.yaml}} contains the definition of two jobs:
> {{cassandra}} and {{cassandra-5.0}}.
> This does not work when {{.build/run-ci}} determines job name:
> {code}
> def determine_job_name(cassandra_dir: Path) -> str:
> """
> Determines the default Jenkins job name based on the Cassandra version.
> Separate jobs are required because Jenkinsfiles are baked into the job
> configuration.
> ref: .jenkins/k8s/jenkins-deployment.yaml JCasC.configScripts.test-job
> TODO: add new version each release branching
> """
> with open(cassandra_dir / "build.xml", "r", encoding="utf-8") as
> build_file:
> for line in build_file:
> if 'property' in line and 'name="base.version"' in line:
> version = line.split('value="')[1].split('"')[0]
> if version.startswith("5.0."):
> return "cassandra-5.0"
> return "trunk"
> {code}
> When on cassandra-5.0 branch, that is ok, but for trunk it is {{trunk}}, not
> {{cassandra}} so it fails.
> Ways to fix it:
> 1) fix jenkins deployment and probably redeploy, not good, a lot of work and
> unnecessary
> 2) fix {{.build/run-ci}} to return {{cassandra}} instead of {{trunk}} when on
> trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
