smiklosovic commented on code in PR #120:
URL:
https://github.com/apache/cassandra-analytics/pull/120#discussion_r2157533761
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/WriterOptions.java:
##########
@@ -45,6 +45,7 @@ public enum WriterOptions implements WriterOption
COMMIT_THREADS_PER_INSTANCE,
COMMIT_BATCH_SIZE,
SKIP_EXTENDED_VERIFY,
+ SKIP_ROWS_VIOLATING_CONSTRAINTS,
Review Comment:
@frankgh thank you for the review but I am not sure this approach is still
viable based on the discussion in the related ticket. Did I interpret that
comment correctly when I think that what I did here is itself not enough to
consider CASSANALYTICS-32 to be resolved as we need to expose failed rows
_somehow_, but this I am trying to do here is a nice to have / first step
towards that direction which is valuable already to have as such?
https://issues.apache.org/jira/browse/CASSANALYTICS-32?focusedCommentId=17980384&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17980384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
