[
https://issues.apache.org/jira/browse/CASSANDRA-20691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955067#comment-17955067
]
Yuqi Yan edited comment on CASSANDRA-20691 at 5/30/25 12:31 AM:
----------------------------------------------------------------
Okay i guess this is fixed very recently by this diff in trunk:
[https://github.com/apache/cassandra/commit/c10c84b9cd3839404184df3669f8cd9a20a46524#diff-8f8f5614b32b053ffd754ddb12406eb656f35ed36e8f70514aeff83ff7b3eb78R714]
Shall we merge this back to 4.1?
(PR for 4.1: https://github.com/apache/cassandra/pull/4187)
was (Author: JIRAUSER301388):
Okay i guess this is fixed very recently by this diff in trunk:
[https://github.com/apache/cassandra/commit/c10c84b9cd3839404184df3669f8cd9a20a46524#diff-8f8f5614b32b053ffd754ddb12406eb656f35ed36e8f70514aeff83ff7b3eb78R714]
Shall we merge this back to 4.1?
> Transport queue timeout is not applied to Paxos v2 LWT
> ------------------------------------------------------
>
> Key: CASSANDRA-20691
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20691
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Legacy/Core
> Reporter: Yuqi Yan
> Assignee: Yuqi Yan
> Priority: Normal
> Fix For: 4.1.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/CASSANDRA-19534
> The goal of the ticket was to apply request timeouts based on the task's
> enqueue or receive time, rather than starting the timeout clock only after
> the task is dequeued for processing.
> {code:java}
> public static RowIterator cas(DecoratedKey key,
> CASRequest request,
> ConsistencyLevel consistencyForConsensus,
> ConsistencyLevel consistencyForCommit,
> ClientState clientState)
> throws UnavailableException, IsBootstrappingException,
> RequestFailureException, RequestTimeoutException, InvalidRequestException
> {
> final long start = nanoTime();
> ^^^^
> final long proposeDeadline = start +
> getCasContentionTimeout(NANOSECONDS);
> final long commitDeadline = Math.max(proposeDeadline, start +
> getWriteRpcTimeout(NANOSECONDS));
> return cas(key, request, consistencyForConsensus,
> consistencyForCommit, clientState, start, proposeDeadline, commitDeadline);
> } {code}
> It appears that the LWT path for Paxos v2 was missed in the current branch.
> As a result, timeouts for LWTs may still be measured from the point of
> dequeuing, which can lead to inconsistent or delayed timeout behavior under
> high load.
> I have a patch ready and will share shortly
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
