This is an automated email from the ASF dual-hosted git repository.

smiklosovic pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/cassandra-sidecar.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 09db580a CASSSIDECAR-251: remove file:// from sidecar.logdir property
09db580a is described below

commit 09db580a7cafe45f6cf246c39f4bd16b7bf5fa0f
Author: Stefan Miklosovic <smikloso...@apache.org>
AuthorDate: Fri May 23 11:16:32 2025 +0200

    CASSSIDECAR-251: remove file:// from sidecar.logdir property
    
    patch by Stefan Miklosovic; reviewed by Francisco Guerrero for 
CASSSIDECAR-251
---
 CHANGES.txt  | 3 ++-
 build.gradle | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/CHANGES.txt b/CHANGES.txt
index abf86a0a..57e87c30 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,6 +1,7 @@
 0.2.0
 -----
- * Add APP_HOME prefix for log config and log dir in cassandra-sidecar startup 
script (CASSSIDECAR-248)
+ * remove file:// from sidecar.logdir property (CASSSIDECAR-251)
+ * Add APP_HOME prefix for log config and log dir in cassandra-sidecar startup 
script (CASSSIDECAR-247)
  * Do not emit warning on startup when initialDelay is configured to 0 
(CASSSIDECAR-248)
  * Improved Documentation on IDE Integration (CASSSIDECAR-227)
  * Schema Reporting Metrics Improvements (CASSSIDECAR-231)
diff --git a/build.gradle b/build.gradle
index ad43d4d0..b09e2d18 100644
--- a/build.gradle
+++ b/build.gradle
@@ -166,7 +166,8 @@ startScripts {
         // Config file location should be in file:/// format for local files,
         def confFile = "file:" + File.separator + File.separator + 
"\${APP_HOME}/conf/sidecar.yaml"
         def logbackConfFile = "file:" + File.separator + File.separator + 
"\${APP_HOME}/conf/logback.xml"
-        def logDir = "file:" + File.separator + File.separator + 
"\${APP_HOME}/logs"
+        // intentionally not added file:// as that is not doing well with 
logback
+        def logDir = "\${APP_HOME}/logs"
 
         // As of Gradle version 7.2, the generated bin/cassandra-sidecar file 
by default is configured to not allow
         // shell fragments. Thus, variables like APP_HOME are treated as 
literals, which prevents us from being able to


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to