anderoo commented on code in PR #93:
URL:
https://github.com/apache/cassandra-analytics/pull/93#discussion_r2079300925
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java:
##########
@@ -53,6 +53,11 @@ public class ClientConfig
public static final String SNAPSHOT_NAME_KEY = "snapshotName";
public static final String DC_KEY = "dc";
public static final String CREATE_SNAPSHOT_KEY = "createSnapshot";
+ /**
+ * Option to filter distinct instances before creating snapshots. This is
only applicable when
+ * using vnodes where the token ring will contain multiple entries per
instance.
+ */
+ public static final String CREATE_SNAPSHOT_FILTER_DISTINCT_INSTANCES_KEY =
"createSnapshotFilterDistinctInstances";
Review Comment:
I'm in agreement here. The Sidecar will throw an error if we try to create
the same snapshot multiple times on the same host so it makes sense for this to
be the default logic. Regarding uniqueness, is FQDN sufficient or would we
prefer FQDN+Port?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
