[
https://issues.apache.org/jira/browse/CASSANDRA-20429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947282#comment-17947282
]
Stefan Miklosovic commented on CASSANDRA-20429:
-----------------------------------------------
Actually, I found some issues as I was taking a look for the last time.
First of all, we have this still in logback.xml
{code:java}
<jmxConfigurator />
{code}
but this is in the logs:
{code}
11:23:42,456 |-WARN in ch.qos.logback.core.model.processor.ImplicitModelHandler
- Ignoring unknown property [jmxConfigurator] in
[ch.qos.logback.classic.LoggerContext]
{code}
So we should remove it.
Secondly, in StorageServiceMBean, we have
{code}
public void setLoggingLevel(String classQualifier, String level) throws
Exception;
{code}
Similarly in NodeProbe:
{code}
public void setLoggingLevel(String classQualifier, String level)
{
try
{
ssProxy.setLoggingLevel(classQualifier, level);
}
catch (Exception e)
{
throw new RuntimeException("Error setting log for " +
classQualifier + " on level " + level + ". Please check logback configuration
and ensure to have <jmxConfigurator /> set", e);
}
}
{code}
We could set logging level via JMX via nodetool. So if we go to update it, this
will not work anymore.
I am not completely sure what consequences it has and it suddenly makes this
ticket more complicated than it seems. We should let people know that this is
(most probably) going away. If they are against it, we can not update.
> Upgrade logback to 1.5.x
> ------------------------
>
> Key: CASSANDRA-20429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20429
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Observability/Logging
> Reporter: Brandon Williams
> Assignee: Nikolay Izhikov
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The logback version we use (1.2.x) is no longer maintained and 1.3.x and
> 1.4.x are inactive. I looked into upgrading in CASSANDRA-20408 and it's more
> involved than a drop-in replacement so I thought it warranted its own jira
> ticket.
> https://logback.qos.ch/download.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
