anderoo commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-2829775647
Hi @bbotella @jberragan. Thanks for the review and sorry fro the delay in follow up. I've added the necessary piping for tests and an initial test for when the feature flag is set. The only issue I'm currently facing is how to test the failure case when the flag isn't set, if this is something we want to test... The problem is: - FileAlreadyExistsException is present in logs but doesn't lead to an error being thrown (We could hook into logs) - The availabilityHints is grouped by host rather than token an the output isn't consistent when _some_ snapshots fail - For failure to happen under these cases I'm guessing we'd need the consistency to fail due to availability hints Would appreciate any suggestions you have on improving the testing here or if things look good as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
