yifan-c commented on code in PR #108: URL: https://github.com/apache/cassandra-analytics/pull/108#discussion_r2059218953
########## cassandra-analytics-sidecar-client/src/main/java/org/apache/cassandra/clients/Sidecar.java: ########## @@ -32,19 +32,19 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import o.a.c.sidecar.client.shaded.common.response.NodeSettings; -import o.a.c.sidecar.client.shaded.io.vertx.core.Vertx; -import o.a.c.sidecar.client.shaded.io.vertx.core.VertxOptions; +import io.vertx.core.Vertx; +import io.vertx.core.VertxOptions; +import org.apache.cassandra.sidecar.common.client.SidecarInstance; +import org.apache.cassandra.sidecar.common.client.SidecarInstanceImpl; +import org.apache.cassandra.sidecar.common.response.NodeSettings; +import org.apache.cassandra.sidecar.vertxclient.VertxHttpClient; +import org.apache.cassandra.sidecar.vertxclient.VertxRequestExecutor; Review Comment: I think we still want to shade the sidecar client subproject and reference to the shadow jar. The idea is to embedding the sidecar client as a whole (shadow jar) w/o conflicting with any existing dependencies in analytics and spark. Just like what we already do for cassandra-all. See `:cassandra-four-zero` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
