[
https://issues.apache.org/jira/browse/CASSSIDECAR-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17942307#comment-17942307
]
Doug Rohrer commented on CASSSIDECAR-231:
-----------------------------------------
+1 from me - thanks for the cleanup work.
> Schema Reporting Metrics Improvements
> -------------------------------------
>
> Key: CASSSIDECAR-231
> URL: https://issues.apache.org/jira/browse/CASSSIDECAR-231
> Project: Sidecar for Apache Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Yuriy Semchyshyn
> Assignee: Yuriy Semchyshyn
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There currently are a few minor flaws in the Cassandra Sidecar codebase that
> interfere with the convenience of using custom server metrics:
> * Constant {{DOMAIN}} in class {{SchemaReportingMetrics}} shall be made
> {{public}} rather than {{protected}};
> * An additional {{protected}} constructor shall be added into the
> {{SchemaReporter}} class to simplify its use with custom metric
> implementation objects;
> * All server metric classes shall be moved into the
> {{org.apache.cassandra.sidecar.metrics.server}} package, consistent with the
> existing instance metrics in the
> {{org.apache.cassandra.sidecar.metrics.instance}} package.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
