[ https://issues.apache.org/jira/browse/CASSANDRA-20402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940158#comment-17940158 ]
Ekaterina Dimitrova commented on CASSANDRA-20402: ------------------------------------------------- With the last change https://github.com/apache/cassandra/pull/3955/files#diff-5cddfa459aa739fe34f47d3a810b0f88168b84a7510d6428abc9b60c6a649a32R851 _secondary_indexes_test.py::TestSecondaryIndexes::test_failing_manual_rebuild_index_ was failing that the index is not available. That seems like a regression to me. Originally, I made that change because _testReadOnlyIndex_ and _testWriteOnlyIndex_ were failing, and it seemed like a miss that _markIndexFailed_ was not marking the index as failed but reading through CASSANDRA-13606; this may have been intentional? In that sense, I guess the right fix for _testWriteOnlyInde_x and _testReadOnlyIndex_ is to change the type of exception - _IndexBuildInProgressException_. So I'd say changing _testReadOnlyIndex_ and _testWriteOnlyIndex_ exceptions is probably the right way to fix this. [~maedhroz], what do you think? > Create new RequestFailureReason - INDEX_BUILDING and return it to end users > while an index is building > ------------------------------------------------------------------------------------------------------ > > Key: CASSANDRA-20402 > URL: https://issues.apache.org/jira/browse/CASSANDRA-20402 > Project: Apache Cassandra > Issue Type: Improvement > Components: Feature/2i Index, Feature/SAI > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 5.x > > > Currently, we return INDEX NOT AVAILABLE to the users while an index is > building, which makes it unclear to users whether the index is building or > there is an issue. > Differentiate the two cases by adding INDEX_BUILDING. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org