[ 
https://issues.apache.org/jira/browse/CASSANDRA-20509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940488#comment-17940488
 ] 

Dmitry Konstantinov edited comment on CASSANDRA-20509 at 4/2/25 10:26 PM:
--------------------------------------------------------------------------

Hm, interesting, it looks like the test had not only flakiness issue..
In JDK8 the capacity value was stored in  java.nio.Bits in a "long" field, 
since Java 11 the value is in "AtomicLong" but we tried to get it as long using 
"BITS_TOTAL_CAPACITY.getLong(null)" before CASSANDRA-19022..
so, before CASSANDRA-19022 we actually get always "-1" as a value for the 
column and the logic to check direct byte buffer usage actually did not work, 
not it works and we see that the test assumptions about direct buffer usage are 
not valid..


was (Author: dnk):
Hm, interesting, it looks like the test had not only flakiness issue..
In JDK8 the capacity value was stored in  java.nio.Bits in a "long" field, 
since Java 11 the value is in "AtomicLong" but we tried to get it as long using 
"BITS_TOTAL_CAPACITY.getLong(null)" before CASSANDRA-19022..
so, before CASSANDRA-19022 we actually get always "-1" as a value for the 
column and the logic to check direct byte buffer usage actually did not work..

> Test failure: largecolumn_test.TestLargeColumn.test_cleanup
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-20509
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20509
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/python
>            Reporter: Dmitry Konstantinov
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>
> https://ci-cassandra.apache.org/job/Cassandra-trunk/2086/#showFailuresLink 
> TestLargeColumn.test_cleanup starts to fail since 2086 build.
> It was flaky some time ago but I fixed it and it was stable: CASSANDRA-19702



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to