[
https://issues.apache.org/jira/browse/CASSSIDECAR-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940184#comment-17940184
]
Yifan Cai commented on CASSSIDECAR-235:
---------------------------------------
+1
> Improvements to CDCConfig classes
> ---------------------------------
>
> Key: CASSSIDECAR-235
> URL: https://issues.apache.org/jira/browse/CASSSIDECAR-235
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
> Reporter: Jyothsna Konisa
> Priority: Urgent
>
> *Improvement 1:*
> `Service.java` class has two enums for storing configs of CDC & KAFKA.
> `Service ConfigAccessorImpl.service()` is making it difficult to extend the
> class `ConfigAccessorImpl` to store configs other than the above enums, as
> the new config's name should be present in the `Service` enum and we can't
> create Service for non-existent values down stream.
> If `ConfigAccessorImpl.service()` is changed to return string, other configs
> can be stored in configs table with new service name.
> *Improvement 2:*
> `CdcConfigImpl` can take `SidecarConfiguration` instead of individual
> CdcConfigAccessor & KafkaConfigAccessor in constructor parameters. This would
> avoid Guice initialization errors in integration tests where there are
> bindings for `SidecarConfiguration` but not for individual configurations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
