[ https://issues.apache.org/jira/browse/CASSANDRA-20485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938754#comment-17938754 ]
Dmitry Konstantinov edited comment on CASSANDRA-20485 at 3/26/25 11:18 PM: --------------------------------------------------------------------------- Hi [~mck], do we have somewhere documented what exact Cassandra versions were used to generate each SSTable file? Probably we can render a text file with Cassandra version/commit id used to generate the files in testGenerateSstables() to document the files origin. For .keep files it would be helpful to add a comment as a content with a clarification why do we have the directories empty for some of format versions (it does not look obvious sometimes, for example why there is an empty directory in a sequence of non-empty versions: legacy_me_tuple is not empty, legacy_na_tuple is empty, legacy_nb_tuple is not empty) was (Author: dnk): Hi [~mck], do we have somewhere documented what exact Cassandra versions were used to generate each SSTable file? Probably we can render a text file with Cassandra version/commit id used to generate the files in testGenerateSstables() to document where the files origin. For .keep files it would be helpful to add a comment as a content with a clarification why do we have the directories empty for some of format versions (it does not look obvious sometimes, for example why there is an empty directory in a sequence of non-empty versions: legacy_me_tuple is not empty, legacy_na_tuple is empty, legacy_nb_tuple is not empty) > Add LegacySSTable test data for different sstable formats > --------------------------------------------------------- > > Key: CASSANDRA-20485 > URL: https://issues.apache.org/jira/browse/CASSANDRA-20485 > Project: Apache Cassandra > Issue Type: Task > Components: Local/SSTable, Test/unit > Reporter: Michael Semb Wever > Assignee: Michael Semb Wever > Priority: Normal > Fix For: 5.0.x, 5.x > > > Spin-off of CASSANDRA-20394 > Adds more test methods and test data (different past sstable formats) to > LegacySSTableTest. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org