[
https://issues.apache.org/jira/browse/CASSANDRA-20394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938671#comment-17938671
]
Michael Semb Wever commented on CASSANDRA-20394:
------------------------------------------------
We ([~jlewandowski] and I) can no longer reproduce any situation where the
header fix is actually needed. SSTables from 3.0.x that we know are written
with the wrong headers are loading fine into 3.11 (3.11.5 and 3.11.latest
tested).
So let's leave that ticket open, if something hits it then we can apply it. I
am going to create a separate ticket that covers just the addition of legacy
test data for the different sstable formats…
> Restore SSTableHeaderFix for use with StandaloneScrubber for offline upgrade
> compatibility
> ------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-20394
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20394
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Local/SSTable, Tool/sstable
> Reporter: Michael Semb Wever
> Assignee: Michael Semb Wever
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We aim to maintain offline compatibility.
> In CASSANDRA-18504 SSTableHeaderFix and the header-fix options from
> StandaloneScrubber were removed in 5.0. This broke offline compatibility
> from <= me sstables written from 3.0.x versions.
> While we don't need online compatibility against such old sstables, we should
> maintain the ability to be able to offline upgrade, including being able to
> fix incompatible/broken headers related to dropped non-explicit frozen UDTs.
> See CASSANDRA-15035 for more info on how headers can be broken and when the
> fix is needed.
> Along with restoring the header fix tooling ability, this ticket also adds
> more test methods and test data (different past sstable formats) to
> LegacySSTableTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
