[ 
https://issues.apache.org/jira/browse/CASSANDRA-19022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938542#comment-17938542
 ] 

Stefan Miklosovic edited comment on CASSANDRA-19022 at 3/26/25 11:13 AM:
-------------------------------------------------------------------------

I have taken what [~maoling] did and reworked how gcstats displays the output

https://github.com/apache/cassandra/pull/4011

{code}
12:05 $ ./bin/nodetool gcstats -H -F json
{
  "interval_ms" : "62171",
  "max_gc_elapsed_ms" : "261",
  "total_gc_elapsed_ms" : "365",
  "stdev_gc_elapsed_ms" : "103",
  "gc_reclaimed_mb" : "270.22 MiB",
  "collections" : "3",
  "direct_memory_bytes" : "43.33 MiB",
  "max_direct_memory_bytes" : "989.88 MiB",
  "reserved_direct_memory_bytes" : "43.33 MiB"
}
✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:09 $ ./bin/nodetool gcstats -H -F yaml
interval_ms: '10795'
max_gc_elapsed_ms: '92'
total_gc_elapsed_ms: '181'
stdev_gc_elapsed_ms: '2'
gc_reclaimed_mb: 28.51 MiB
collections: '2'
direct_memory_bytes: 43.31 MiB
max_direct_memory_bytes: 989.88 MiB
reserved_direct_memory_bytes: 43.31 MiB

✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:09 $ ./bin/nodetool gcstats -H 
Interval (ms)                8658      
Max GC Elapsed (ms)          86        
Total GC Elapsed (ms)        171       
Stdev GC Elapsed (ms)        1         
GC Reclaimed Bytes           17.3 MiB  
Collections                  2         
Total Direct Memory Bytes    43.31 MiB 
Max Direct Memory Bytes      989.88 MiB
Reserved Direct Memory Bytes 43.31 MiB 
✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:09 $ ./bin/nodetool gcstats 
Interval (ms)                7841      
Max GC Elapsed (ms)          87        
Total GC Elapsed (ms)        171       
Stdev GC Elapsed (ms)        2         
GC Reclaimed Bytes           18653592  
Collections                  2         
Total Direct Memory Bytes    45416426  
Max Direct Memory Bytes      1037959168
Reserved Direct Memory Bytes 45416428  
✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:10 $ ./bin/nodetool gcstats -F json
{
  "interval_ms" : "14699",
  "max_gc_elapsed_ms" : "91",
  "total_gc_elapsed_ms" : "181",
  "stdev_gc_elapsed_ms" : "1",
  "gc_reclaimed_mb" : "19152352",
  "collections" : "2",
  "direct_memory_bytes" : "45416426",
  "max_direct_memory_bytes" : "1037959168",
  "reserved_direct_memory_bytes" : "45416428"
}
✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:10 $ ./bin/nodetool gcstats -F yaml
interval_ms: '11771'
max_gc_elapsed_ms: '91'
total_gc_elapsed_ms: '258'
stdev_gc_elapsed_ms: '4'
gc_reclaimed_mb: '25082272'
collections: '3'
direct_memory_bytes: '45416426'
max_direct_memory_bytes: '1037959168'
reserved_direct_memory_bytes: '45416428'

{code}


was (Author: smiklosovic):
I have took what [~maoling] did and reworked how gcstats displays the output

https://github.com/apache/cassandra/pull/4011

{code}
12:05 $ ./bin/nodetool gcstats -H -F json
{
  "interval_ms" : "62171",
  "max_gc_elapsed_ms" : "261",
  "total_gc_elapsed_ms" : "365",
  "stdev_gc_elapsed_ms" : "103",
  "gc_reclaimed_mb" : "270.22 MiB",
  "collections" : "3",
  "direct_memory_bytes" : "43.33 MiB",
  "max_direct_memory_bytes" : "989.88 MiB",
  "reserved_direct_memory_bytes" : "43.33 MiB"
}
✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:09 $ ./bin/nodetool gcstats -H -F yaml
interval_ms: '10795'
max_gc_elapsed_ms: '92'
total_gc_elapsed_ms: '181'
stdev_gc_elapsed_ms: '2'
gc_reclaimed_mb: 28.51 MiB
collections: '2'
direct_memory_bytes: 43.31 MiB
max_direct_memory_bytes: 989.88 MiB
reserved_direct_memory_bytes: 43.31 MiB

✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:09 $ ./bin/nodetool gcstats -H 
Interval (ms)                8658      
Max GC Elapsed (ms)          86        
Total GC Elapsed (ms)        171       
Stdev GC Elapsed (ms)        1         
GC Reclaimed Bytes           17.3 MiB  
Collections                  2         
Total Direct Memory Bytes    43.31 MiB 
Max Direct Memory Bytes      989.88 MiB
Reserved Direct Memory Bytes 43.31 MiB 
✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:09 $ ./bin/nodetool gcstats 
Interval (ms)                7841      
Max GC Elapsed (ms)          87        
Total GC Elapsed (ms)        171       
Stdev GC Elapsed (ms)        2         
GC Reclaimed Bytes           18653592  
Collections                  2         
Total Direct Memory Bytes    45416426  
Max Direct Memory Bytes      1037959168
Reserved Direct Memory Bytes 45416428  
✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:10 $ ./bin/nodetool gcstats -F json
{
  "interval_ms" : "14699",
  "max_gc_elapsed_ms" : "91",
  "total_gc_elapsed_ms" : "181",
  "stdev_gc_elapsed_ms" : "1",
  "gc_reclaimed_mb" : "19152352",
  "collections" : "2",
  "direct_memory_bytes" : "45416426",
  "max_direct_memory_bytes" : "1037959168",
  "reserved_direct_memory_bytes" : "45416428"
}
✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [CASSANDRA-19022 L|⚑ 158] 
12:10 $ ./bin/nodetool gcstats -F yaml
interval_ms: '11771'
max_gc_elapsed_ms: '91'
total_gc_elapsed_ms: '258'
stdev_gc_elapsed_ms: '4'
gc_reclaimed_mb: '25082272'
collections: '3'
direct_memory_bytes: '45416426'
max_direct_memory_bytes: '1037959168'
reserved_direct_memory_bytes: '45416428'

{code}

> Nodetool gcstats correctly displays Direct Memory usage and supports printing 
> in table format
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-19022
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19022
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Tool/nodetool
>            Reporter: Brad Schoening
>            Assignee: Ling Mao
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If {{io.netty.maxDirectMemory}} is not specified, Netty defaults the limit to 
> the max heap size.  Thus, direct memory in use can be significant.
> However, trying this on two different platform and the result returned in 
> gcstats is always -1:
> {noformat}
> Interval (ms) Max GC Elapsed (ms)Total GC Elapsed (ms)Stdev GC Elapsed (ms)   
> GC Reclaimed (MB)         Collections      Direct Memory Bytes
> 2792770717                 274              665186                  54      
> 41276288089024                6120                       -1{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to