[ 
https://issues.apache.org/jira/browse/CASSANDRA-20448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936827#comment-17936827
 ] 

Stefan Miklosovic commented on CASSANDRA-20448:
-----------------------------------------------

whole tool is very ... "basic" when it comes to argument parsing, there are 
also tests (SSTableExpiredBlockersTest) which are pretty opinionated about how 
arguments are parsed (e.g. testWrongArgsIgnored). It is not like I prefer this 
too much but I am trying to incorporate it into what already exists to not 
break anything else. 

> Utility sstableexpiredblockers should report the size of expired tables
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-20448
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20448
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Tools
>            Reporter: Brad Schoening
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> A key reason to run sstableexpiredblockers is that you have disk space 
> accumulating and you wish to investigate what's consuming the disk space.
> If size was included in the output (as shown below), it would make the output 
> more useful. Generally, when you find a blocked expired table, the first step 
> is to check what size it is to see if it's large enough to be a problem.
> {quote}[BigTableReader(path='/var/lib/cassandra/data/keyspace1/standard1-0665ae80b2d711e886c66d2c86545d91/mc-2-big-Data.db')
>  (minTS = 5, maxTS = 5, maxLDT = 2147483647)], blocks 1 expired sstables from 
> getting dropped: 
> [BigTableReader(path='/var/lib/cassandra/data/keyspace1/standard1-0665ae80b2d711e886c66d2c86545d91/mc-3-big-Data.db')
>  (\{*}diskSize = 135.7 GB\{*}, minTS = 1536349775157606, maxTS = 
> 1536349780311159, maxLDT = 1536349780)],
> {quote}
> Also, it would be preferable to report min/max timestamp in date-time format 
> e.g.:
> {quote}        diskSize =134.3 GB, minTimestamp = 
> 2025-03-10T00:00:00.000+00:00
> {quote}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to