[
https://issues.apache.org/jira/browse/CASSANDRA-20363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932639#comment-17932639
]
Tommy Stendahl edited comment on CASSANDRA-20363 at 3/6/25 7:52 AM:
--------------------------------------------------------------------
I took a look at the unit tests and I could see that a bunch of commit log
related tests are failing. This seams to be due to the
{{{}NoOpDiskErrorObserver{}}}, if I set it to {{DefaultDiskErrorsHandler}} the
tests are working.
-Maybe {{DiskErrorsHandler.setInstance(DiskErrorsHandler newInstance)}} should
return the old instance so we replace it at the end of tests like we do with
other things.- Since we do init()/close() this is probably not a good idea.
was (Author: tommy_s):
I took a look at the unit tests and I could see that a bunch of commit log
related tests are failing. This seams to be due to the
{{{}NoOpDiskErrorObserver{}}}, if I set it to {{DefaultDiskErrorsHandler}} the
tests are working.
Maybe {{DiskErrorsHandler.setInstance(DiskErrorsHandler newInstance)}} should
return the old instance so we replace it at the end of tests like we do with
other things.
> Introduce a robust way to intercept FSError and commit log errors
> -----------------------------------------------------------------
>
> Key: CASSANDRA-20363
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20363
> Project: Apache Cassandra
> Issue Type: New Feature
> Components: Legacy/Core
> Reporter: Tommy Stendahl
> Assignee: Tommy Stendahl
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add java property to override the DefaultFSErrorHandler with a custom
> implementation.
> The use case I am looking at is a customer deployment that are using network
> disks and these can go off-line sometimes, I would like to use
> "disk_failure_policy: stop" but automatically detect when the disk is on-line
> again and just open gossip and transports so the nodes comes back UP without
> triggering a restart of the node.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
