[
https://issues.apache.org/jira/browse/CASSANDRA-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933041#comment-17933041
]
Dmitry Konstantinov commented on CASSANDRA-20396:
-------------------------------------------------
I checked similar places in SSTableSimpleScanner proximity and probably we also
need to add a logic like this:
{code:java}
catch (CorruptSSTableException e) // to ensure that we marked the sstable as
suspected
{
sstable.markSuspect();
throw e;
} {code}
to org.apache.cassandra.io.sstable.SSTableIdentityIterator#create() because it
does reads and we can throw CorruptSSTableException from
org.apache.cassandra.io.util.CompressedChunkReader.Standard#readChunk() but we
do not invoke markSuspect on that level.
An alternative can be not covert CorruptBlockException (which is IOException)
to CorruptSSTableException within CompressedChunkReader.Standard#readChunk but
I am not sure about a global impact for this change..
> Test failure: CorruptedSSTablesCompactionsTest
> ----------------------------------------------
>
> Key: CASSANDRA-20396
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20396
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Local/SSTable
> Reporter: Dmitry Konstantinov
> Assignee: Dmitry Konstantinov
> Priority: Normal
> Fix For: 5.x
>
> Attachments:
> TEST-org.apache.cassandra.db.compaction.CorruptedSSTablesCompactionsTest.log.xz,
>
> TEST-org.apache.cassandra.db.compaction.CorruptedSSTablesCompactionsTest.xml.xz,
> image-2025-03-04-21-46-34-829.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> CorruptedSSTablesCompactionsTest is failing for trunk on CI:
> * [https://ci-cassandra.apache.org/job/Cassandra-trunk/2049/]
> * [https://ci-cassandra.apache.org/job/Cassandra-trunk/2044/]
> *
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/2043/|https://ci-cassandra.apache.org/job/Cassandra-trunk/2043/#showFailuresLink]
> with errors like:
> {code:java}
> junit.framework.AssertionFailedError: expected:<8> but was:<25>
> at
> org.apache.cassandra.db.compaction.CorruptedSSTablesCompactionsTest.testCorruptedSSTables(CorruptedSSTablesCompactionsTest.java:267)
> at
> org.apache.cassandra.db.compaction.CorruptedSSTablesCompactionsTest.testCorruptedSSTablesWithSizeTieredCompactionStrategy(CorruptedSSTablesCompactionsTest.java:146)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> {code}
> note: the failure is observing for test-compression suite
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
