tengu-alt commented on issue #953: URL: https://github.com/apache/cassandra-gocql-driver/issues/953#issuecomment-2674005327
> it would be more helpful to state your proposal I've done some research and see that happens because `exec()` method considers both (`Conn` and `ctx`) timeouts. And handles the first one that expires ([here](https://github.com/apache/cassandra-gocql-driver/blob/trunk/conn.go#L1150)). That affects query custom timeout, you can set it to less than Connection timeout and that will work, but if it's bigger than `connection` timeout - it won't be taken into account. That is half of the functional. I suggest that we ignore the `Conn.timeout` if `ctx` parameter has a deadline (just don't fall into condition [here](https://github.com/apache/cassandra-gocql-driver/blob/trunk/conn.go#L1102)) (also `exec()` considers the context of the connection, but in case the connection closed itself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
