yifan-c commented on code in PR #80:
URL:
https://github.com/apache/cassandra-analytics/pull/80#discussion_r1756085954
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/token/TokenRangeMapping.java:
##########
@@ -113,12 +139,10 @@ Multimap<I, Range<BigInteger>>
tokenRangesByInstance(List<ReplicaInfo> writeRepl
}
public TokenRangeMapping(Partitioner partitioner,
- ReplicationFactor replicationFactor,
Review Comment:
Since `TokenRangeMapping` now can be consolidated, it no longer makes sense
to contain ReplicationFactor, which is tie to cluster.
The `TokenRangeMapping` or topology is only to describe the ring layout.
`ReplicationFactor` is for consistency coordination. It is not part of
`TokenRangeMapping` at the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
