[ https://issues.apache.org/jira/browse/CASSANDRA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878528#comment-17878528 ]
Stefan Miklosovic commented on CASSANDRA-12937: ----------------------------------------------- [CASSANDRA-12937-squashed|https://github.com/instaclustr/cassandra/tree/CASSANDRA-12937-squashed] {noformat} java17_pre-commit_tests ✓ j17_build 4m 29s ✓ j17_cqlsh_dtests_py311 6m 59s ✓ j17_cqlsh_dtests_py311_vnode 7m 31s ✓ j17_cqlsh_dtests_py38 6m 55s ✓ j17_cqlsh_dtests_py38_vnode 7m 18s ✓ j17_cqlshlib_cython_tests 7m 39s ✓ j17_cqlshlib_tests 6m 48s ✓ j17_dtests 32m 54s ✓ j17_unit_tests 12m 22s ✓ j17_utests_latest 14m 31s ✓ j17_utests_oa 13m 18s ✕ j17_dtests_latest 35m 11s bootstrap_test.TestBootstrap test_consistent_range_movement_false_with_replica_down_should_succeed ✕ j17_dtests_vnode 43m 44s bootstrap_test.TestBootstrap test_consistent_range_movement_false_with_replica_down_should_succeed bootstrap_test.TestBootstrap test_killed_wiped_node_cannot_join ✕ j17_jvm_dtests 21m 34s org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testOptionalMtlsModeDoNotAllowNonSSLConnections ✕ j17_jvm_dtests_latest_vnode 23m 5s org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest testMoveToCMS java11_pre-commit_tests ✓ j11_build 7m 29s ✓ j11_cqlsh_dtests_py311 9m 49s ✓ j11_cqlsh_dtests_py311_vnode 9m 52s ✓ j11_cqlsh_dtests_py38 10m 0s ✓ j11_cqlsh_dtests_py38_vnode 9m 57s ✓ j11_cqlshlib_cython_tests 14m 19s ✓ j11_cqlshlib_tests 11m 4s ✓ j11_dtests_vnode 37m 46s ✓ j11_jvm_dtests 27m 2s ✓ j11_simulator_dtests 4m 43s ✓ j11_unit_tests 14m 41s ✓ j11_utests_latest 13m 57s ✓ j11_utests_oa 17m 7s ✓ j11_utests_system_keyspace_directory 13m 9s ✓ j17_cqlsh_dtests_py311 6m 57s ✓ j17_cqlsh_dtests_py311_vnode 7m 39s ✓ j17_cqlsh_dtests_py38 6m 34s ✓ j17_cqlsh_dtests_py38_vnode 7m 26s ✓ j17_cqlshlib_cython_tests 8m 14s ✓ j17_cqlshlib_tests 7m 1s ✓ j17_unit_tests 12m 44s ✓ j17_utests_latest 14m 36s ✓ j17_utests_oa 12m 55s ✕ j11_dtests 35m 18s pushed_notifications_test.TestPushedNotifications test_move_single_node_localhost counter_test.TestCounters test_counter_node_down ✕ j11_dtests_latest 36m 33s bootstrap_test.TestBootstrap test_consistent_range_movement_false_with_rf1_should_succeed ✕ j11_jvm_dtests_latest_vnode 23m 44s org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest testMoveToCMS ✕ j17_dtests 33m 49s rebuild_test.TestRebuild test_simple_rebuild ✕ j17_dtests_latest 35m 28s counter_test.TestCounters test_counter_node_down ✕ j17_dtests_vnode 36m 3s bootstrap_test.TestBootstrap test_consistent_range_movement_false_with_rf1_should_succeed ✕ j17_jvm_dtests 21m 35s org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testOptionalMtlsModeDoNotAllowNonSSLConnections org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest testEndpointVerificationEnabledIpNotInSAN ✕ j17_jvm_dtests_latest_vnode 21m 29s org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest testMoveToCMS junit.framework.TestSuite org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest {noformat} [java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4646/workflows/a403512f-8a04-4a24-b900-bd36dbdcb66f] [java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4646/workflows/43555a7b-b825-429e-ad00-61d6ed1a0739] > Default setting (yaml) for SSTable compression > ---------------------------------------------- > > Key: CASSANDRA-12937 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12937 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config > Reporter: Michael Semb Wever > Assignee: Stefan Miklosovic > Priority: Low > Labels: AdventCalendar2021 > Fix For: 5.x > > Time Spent: 8h 50m > Remaining Estimate: 0h > > In many situations the choice of compression for sstables is more relevant to > the disks attached than to the schema and data. > This issue is to add to cassandra.yaml a default value for sstable > compression that new tables will inherit (instead of the defaults found in > {{CompressionParams.DEFAULT}}. > Examples where this can be relevant are filesystems that do on-the-fly > compression (btrfs, zfs) or specific disk configurations or even specific C* > versions (see CASSANDRA-10995 ). > +Additional information for newcomers+ > Some new fields need to be added to {{cassandra.yaml}} to allow specifying > the field required for defining the default compression parameters. In > {{DatabaseDescriptor}} a new {{CompressionParams}} field should be added for > the default compression. This field should be initialized in > {{DatabaseDescriptor.applySimpleConfig()}}. At the different places where > {{CompressionParams.DEFAULT}} was used the code should call > {{DatabaseDescriptor#getDefaultCompressionParams}} that should return some > copy of configured {{CompressionParams}}. > Some unit test using {{OverrideConfigurationLoader}} should be used to test > that the table schema use the new default when a new table is created (see > CreateTest for some example). -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org