[ https://issues.apache.org/jira/browse/CASSANDRA-19779 ]
Stefan Miklosovic deleted comment on CASSANDRA-19779:
-----------------------------------------------
was (Author: smiklosovic):
[CASSANDRA-19779-5.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19779-5.0]
{noformat}
java17_pre-commit_tests
✓ j17_build 4m 54s
✓ j17_cqlsh_dtests_py311 6m 6s
✓ j17_cqlsh_dtests_py311_vnode 6m 15s
✓ j17_cqlsh_dtests_py38 5m 50s
✓ j17_cqlsh_dtests_py38_vnode 6m 48s
✓ j17_cqlshlib_cython_tests 7m 34s
✓ j17_cqlshlib_tests 8m 50s
✓ j17_dtests 34m 9s
✓ j17_dtests_latest 34m 31s
✓ j17_jvm_dtests 22m 39s
✓ j17_jvm_dtests_latest_vnode 14m 12s
✓ j17_unit_tests 19m 26s
✓ j17_utests_latest 16m 32s
✓ j17_utests_oa 13m 11s
✕ j17_dtests_vnode 34m 21s
bootstrap_test.TestBootstrap test_decommissioned_wiped_node_can_join
java17_separate_tests
✓ j17_build 4m 4s
✓ j17_utests_latest 15m 59s
java11_pre-commit_tests
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4544/workflows/d898baf7-1b1c-4c09-ac44-a483bfe6feba]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4544/workflows/3d7f3adf-7dbb-4cea-82f8-19e111199dfc]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4544/workflows/2165256e-16b3-444f-931e-337fda0050e8]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4544/workflows/abaccc5a-3a3c-49be-bfef-b680fa9f4a24]
> direct IO support is always evaluated to false upon the very first start of a
> node
> ----------------------------------------------------------------------------------
>
> Key: CASSANDRA-19779
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19779
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.0-rc
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When I extract the distribution tarball and I want to use tools in tools/bin,
> there is this warn log visible every time for tools when they are started
> (does not happen on "help" command, obviously)
> {code:java}
> WARN 14:25:11,835 Unable to determine block size for commit log directory:
> null {code}
> This is because we introduced this (1) in CASSANDRA-18464
> What that does is that it will go and try to create a temporary file in
> commit log directory to get "block size" for a "file store" that file is in.
> The problem with that is that when we just extract a tarball and run the
> tools - Cassandra was never started - then such commit log directory does not
> exist yet, so it tries to create a temporary file in a non-existing
> directory, which fails, hence the log message.
> The fix is to check if commitlog dir exists and return / skip the resolution
> of block size if it does not.
> Another approach might be to check if this is executed in the context of a
> tool and skip it from resolution altogether. The problem with this is that
> not all tools we have in bin/log call DatabaseDescriptor.
> toolInitialization() so we might combine these two.
> (1)
> [https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/config/DatabaseDescriptor.java#L1455-L1462]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
