jberragan commented on code in PR #62:
URL:
https://github.com/apache/cassandra-analytics/pull/62#discussion_r1676203192
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/EmptyStreamScanner.java:
##########
@@ -24,13 +24,13 @@ public class EmptyStreamScanner implements
StreamScanner<Rid>
public static final EmptyStreamScanner INSTANCE = new EmptyStreamScanner();
@Override
- public Rid rid()
+ public Rid data()
Review Comment:
I suggest you take a deeper look at `AbstractStreamScanner` and the work
involved in refactoring to an `java.util.Iterator`, `hasNext()` has the
expectation of being idempotent and this is not currently the case for
`AbstractStreamScanner`. I am +1 on moving to `java.util.Iterator` but it
should be handled as an independent PR so it can be reviewed carefully and
tested outside of these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
