frankgh commented on code in PR #62:
URL:
https://github.com/apache/cassandra-analytics/pull/62#discussion_r1674323821
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/reader/StreamScanner.java:
##########
@@ -49,30 +49,31 @@
* <p>
* Upon return from the next() call the current values of the scanner can be
obtained by calling
* the methods in Rid, getPartitionKey(), getColumnName(), getValue().
+ *
* @param <Type> type of object returned by rid() method.
*/
@SuppressWarnings("unused")
public interface StreamScanner<Type> extends Closeable
{
/**
- * Expose the data/rid to be consumed.
- * Implementation note: rid should always be updated to the current
partition if hasNext returns true.
+ * Exposes the data to be consumed.
+ * <p>Implementation note: The data should always be updated to the
current partition if {@code next} returns {@code true}.</p>
*
- * @return rid
+ * @return data of type {@code Type}
*/
- Type rid();
+ Type data();
/**
- * Indicate if there are more data/rid avaiable
+ * Indicate if there are more data avaiable to read.
Review Comment:
```suggestion
* Indicate if there are more data available to read.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
