[ 
https://issues.apache.org/jira/browse/CASSANDRA-19573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17860073#comment-17860073
 ] 

Ling Mao commented on CASSANDRA-19573:
--------------------------------------

 
{code:java}
The trickiest part is ALLOW FILTERING, since it's not easy to determine whether 
a command strictly needs filtering. This check is done during parsing, and the 
concept doesn't exist internally. For that I have just changed the 
implementations of toCQLString to simply always add ALLOW FILTERING. This is 
not ideal but IMO it's correct and consistent with the idea that filtering is 
always allowed internally. I think that SAI will introduce changes around AF 
that would ease to determine whether the command requires filtering.{code}
Reference: https://issues.apache.org/jira/browse/CASSANDRA-16510

 

> incorrect queries showing up in queries virtual table
> -----------------------------------------------------
>
>                 Key: CASSANDRA-19573
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19573
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Virtual Tables
>            Reporter: Jon Haddad
>            Priority: Normal
>             Fix For: 4.1.x, 5.0.x, 5.x
>
>
> While running an easy-cass-stress workload I queried system_views.queries and 
> got this (edited for sanity):
>  
> {noformat}
> thread_id       | queued_micros | running_micros | task
> -----------------+---------------+----------------+----
>  MutationStage-2 |             0 |              0 | 
> Mutation(keyspace='easy_cass_stress', key='3030312e302e3937363535', 
> modifications=[\n  [easy_cass_stress.random_access] key=001.0.97655 
> partition_deletion=deletedAt=-9223372036854775808, localDeletion=2147483647 
> columns=[[] | [value]]\n    Row[info=[ts=1713501354789139] ]: row_id=291 | 
> [value=SXFNPWZDYFHTUSBWMUQCTTRAHQWXMGYOHASTGDFYLILWMOSFQWZGKUAIPUUGCLTADKFFXZRQGKIJJLXNOQKMAIOVSSVMVSFSFAVPABIIHGQSGRPACFWCKYMZMSNZZARSBFVDASTMCRHAVAYHKQDZWFCHRUPDWZJVTEVIWKPMKLAOZGBUDFJVOPSAHLAIWOGNXZHCBVK
>  ts=1713501354789139]\n])
>      ReadStage-4 |             0 |           6216 |  SELECT * FROM 
> easy_cass_stress.random_access WHERE partition_id = '001.0.18474' AND row_id 
> = 746 LIMIT 5000 ALLOW FILTERING
> {noformat}
> What's interesting is that I supply neither a LIMIT or ALLOW FILTERING when I 
> prepared the query.  I assume the limit is coming from the driver, and while 
> it's technically correct from the standpoint of what it does, it's not what I 
> prepared so it's a little weird to see it there.
> The ALLOW FILTERING, on the other hand, was definitely not prepared.
> {noformat}
>  session.prepare("SELECT * from random_access WHERE partition_id = ? and 
> row_id = ?")
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to